Chore: transfer logging to CLI #8
Open
+242
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stellar-rpc-client into feat/GetTransactions
BlaineHeffron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
JSON decoded diagnostic event string is being added to log in the CLI. See stellar/stellar-cli#1447 Currently it is being logged in the RPC client, which should not be the RPC client's job. I am removing it here and will be adding more detailed logging in the CLI.
This PR also modifies the output of the
simulate_and_assemble_transactionto return both theAssembledTransactionand theSimulateTransactionResult. This will allow the CLI and other tools to log anyeventsattached to the result. It also transfers the responsibility of throwing the error to the CLI.Why
CLI should be responsible for logging, see stellar/stellar-cli#1447 (comment)
Known limitations
Breaking change since it removes a log statement when simulations fail. Additionally,
simulate_and_assemble_transactionwill not return an Error when the simulation fails; instead theAssembledTransactionwill be None and the CLI will need to throw the error based on theSimulateTransactionResultwhich is now being returned alongside theAssembledTransaction.