-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run stellar mart DAG at the beginning of day #502
Conversation
bcef14d
to
0bdb882
Compare
update fix task name
0bdb882
to
5d2daae
Compare
334c73f
to
f14ef22
Compare
cdd0eaa
to
1854f99
Compare
13072bb
to
b1d9b21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits, nothing blocking the merge
dags/dbt_recency_tests_dag.py
Outdated
@@ -18,7 +18,7 @@ | |||
default_args=get_default_dag_args(), | |||
start_date=datetime(2024, 9, 24, 0, 0), | |||
description="This DAG runs recency tests at a daily cadence", | |||
schedule="0 20 * * *", # Every day at 8:00 PM UTC / 3:00 PM CST | |||
schedule="0 15 * * *", # Every day at 3:00 PM UTC / 9:00 AM CST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you land on 15:00 UTC? Do you think we could run even earlier? (Like 2:00 or 3:00)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selected 15:00 UTC to have the elementary run at 9 CST. Mostly for convenience to get alerts as we start workday. But can definitely be changed to 2:00/3:00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. we can leave the schedule as is and if we run into issues move it up
@@ -58,9 +57,6 @@ | |||
# DAG task graph | |||
wait_on_dbt_enriched_base_tables >> ohlc_task >> liquidity_pool_trade_volume_task | |||
|
|||
wait_on_dbt_enriched_base_tables >> mgi_task | |||
wait_on_partner_pipeline_dag >> mgi_task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also delete the wait on partner pipeline dag task
PR Checklist
PR Structure
otherwise).
Thoroughness
What
This PR:
Why
To refresh data as early as possible
Known limitations
[TODO or N/A]