Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run stellar mart DAG at the beginning of day #502

Merged
merged 14 commits into from
Oct 4, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Sep 30, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

This PR:

  • Updates the schedule of stellar mart dag so as to refresh data earlier
  • Updates the schedule of recency tests to receive any alerts early in work day
  • Separate MGI task to another DAG based on time when mgi files are received

Why

To refresh data as early as possible

Known limitations

[TODO or N/A]

update

fix task name
@amishas157 amishas157 changed the title Patch/update dag start times Run stellar mart at the start of UTC Oct 3, 2024
@amishas157 amishas157 marked this pull request as ready for review October 3, 2024 21:57
@amishas157 amishas157 requested a review from a team as a code owner October 3, 2024 21:57
@amishas157 amishas157 changed the title Run stellar mart at the start of UTC Run stellar mart DAG at the beginning of day Oct 3, 2024
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, nothing blocking the merge

@@ -18,7 +18,7 @@
default_args=get_default_dag_args(),
start_date=datetime(2024, 9, 24, 0, 0),
description="This DAG runs recency tests at a daily cadence",
schedule="0 20 * * *", # Every day at 8:00 PM UTC / 3:00 PM CST
schedule="0 15 * * *", # Every day at 3:00 PM UTC / 9:00 AM CST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you land on 15:00 UTC? Do you think we could run even earlier? (Like 2:00 or 3:00)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selected 15:00 UTC to have the elementary run at 9 CST. Mostly for convenience to get alerts as we start workday. But can definitely be changed to 2:00/3:00

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. we can leave the schedule as is and if we run into issues move it up

dags/dbt_stellar_marts_mgi_dag.py Show resolved Hide resolved
@@ -58,9 +57,6 @@
# DAG task graph
wait_on_dbt_enriched_base_tables >> ohlc_task >> liquidity_pool_trade_volume_task

wait_on_dbt_enriched_base_tables >> mgi_task
wait_on_partner_pipeline_dag >> mgi_task
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also delete the wait on partner pipeline dag task

@amishas157 amishas157 merged commit d40950b into master Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants