httphandler: tss api endpoints #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding semicolons
…ransaction_hash ...also remove outgoing/incoming_status and have one status column
commit fb807aa Author: gouthamp-stellar <[email protected]> Date: Tue Sep 3 10:28:49 2024 -0700 remove the index on try_transaction_xdr and add column/index on try_transaction_hash ...also remove outgoing/incoming_status and have one status column commit 6fc0dc2 Author: gouthamp-stellar <[email protected]> Date: Tue Sep 3 08:58:46 2024 -0700 missing , commit a9cf4e3 Author: gouthamp-stellar <[email protected]> Date: Tue Sep 3 01:55:23 2024 -0700 make hash primary key instead of xdr commit c0f9d32 Author: gouthamp-stellar <[email protected]> Date: Fri Aug 30 15:18:27 2024 -0700 moving all migrations to one file commit 2de9898 Author: gouthamp-stellar <[email protected]> Date: Fri Aug 30 15:16:53 2024 -0700 adding semicolons adding semicolons commit 373c71a Author: gouthamp-stellar <[email protected]> Date: Fri Aug 30 15:12:24 2024 -0700 update commit 3f9f9f0 Author: gouthamp-stellar <[email protected]> Date: Fri Aug 30 15:12:00 2024 -0700 remove empty lines commit 9920f48 Author: gouthamp-stellar <[email protected]> Date: Fri Aug 30 15:06:40 2024 -0700 TSS tables and the channel interface commit a58d519 Author: gouthamp-stellar <[email protected]> Date: Fri Aug 30 10:55:22 2024 -0700 tables and interfaces for TSS
…and builds a transaction out of it
CaioTeixeira95
approved these changes
Oct 16, 2024
| } | ||
|
|
||
| type Transaction struct { | ||
| Operations []string `json:"operations"` |
There was a problem hiding this comment.
I'd recommend we add validate flag here too.
| endpoint := "/tss/transactions" | ||
|
|
||
| r := chi.NewRouter() | ||
| //r.Get("/tss/{transactionhash}", handler.GetTransaction) |
There was a problem hiding this comment.
Should we remove this line?
Comment on lines
206
to
209
| assert.Equal(t, http.StatusOK, resp.StatusCode) | ||
| assert.Empty(t, getTxResp.Hash) | ||
| assert.Empty(t, getTxResp.XDR) | ||
| assert.Empty(t, getTxResp.Status) |
There was a problem hiding this comment.
I think we could return 404 instead of 200 when the transaction hash doesn't exist.
Comment on lines
108
to
111
| if err != nil { | ||
| httperror.InternalServerError(ctx, "unable to get transaction", err, nil, t.AppTracker).Render(w) | ||
| return | ||
| } |
There was a problem hiding this comment.
Just wondering, should we log the transaction hash explicitly here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
TSS API endpoints to
Why
For clients of TSS to be able to submit transactions and get a transaction that they submitted
Known limitations
N/A
Issue that this PR addresses
https://app.asana.com/0/1207947010297920/1208138733594341
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release