Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for @hubot-friends/hubot-slack adapter #157

Conversation

KeesCBakker
Copy link
Collaborator

The old Slack Hubot adapter is not maintained. Fortunately there is a modern forked version with support for Socket Mode.

The PR implements #156

I'm not sure what testing can be done here, as the adapter should still behave in the same way. I'm still checking if this is locally the case.

@stephenyeargin
Copy link
Owner

@KeesCBakker Code changes look fine and shouldn't disrupt any existing installs. Did you want to do more testing on your end before we merge it in, or is it good to go?

@KeesCBakker
Copy link
Collaborator Author

I've tested it, works fine. I have no clue on how to test it further out in the open. If the adapter keeps working fine I think it will be the new standard for Hubot and Slack.

@stephenyeargin stephenyeargin merged commit ce12708 into stephenyeargin:main Aug 1, 2023
@stephenyeargin
Copy link
Owner

Reading the linked PR from #156, I see that v7 is likely to break the existing implementation anyway if the HUBOT_ADAPTER / adapterName has to include the full package name at load time. Solution is likely to add a handful more cases or a helper method to de-reference the adapterName from the implementation.

@KeesCBakker
Copy link
Collaborator Author

Yeah, and some of them will be prefixed by hubot-. Many developments there, but let's see how far the users of this package get. I cannot imagine ppl moving towards v7 fast.

@stephenyeargin
Copy link
Owner

Attempting to address it in #160.

@KeesCBakker KeesCBakker deleted the feat-support-for-hubotfriends-slack branch August 23, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants