Add a command to navigate to a certain page by incremental search #1044

valuex · 2023-06-04T07:35:17Z

IS YOUR COMMIT SIGNED?

Note that this repo requires all commits to be properly signed, see here for more info
Yes

Enhancement or Defect Addressed by This PR

Navigate to a certain page by incremental search
Move the current page after a selected page

Description of Proposed Changes

a pop-up window with a texbox and HirarchyTreeview
when user input some characters in the textbox, the input chars will be incrementally indexed and the results will be shown in the tree view
to search Pages title with Chinese characters by inputting the first letters of corresponding Chinese PinYin is also supported
Search and NavigateTo
search syntax " Section_name Page_name".
- the first space is taken as a seperator, the chars before the space will be used to search Section Name, while the chars after the space will be used to search Page Name.
- if there is a leading space input into the textbox, e.g. " onemore", only the pages's name will be searched
- NavigateTo: click the underlined page name in the tree view
Move to: one can move the current page after the destination page, which the user checked in the tree view

OneMore/Commands/Navigator/NaviDialog.Designer.cs

OneMore/Commands/Navigator/NaviDialog.cs

OneMore/Commands/Navigator/NaviDialog.resx

stevencohn · 2023-06-04T14:46:00Z

OneMore/Commands/Navigator/NaviPagesCommand.cs

+                        using var one = new OneNote();
+                        //var service = new SearchServices(owner, one, sectionId);
+
+                        if (copying)


Are these operations going to be implemented? If not, remove the code and associated UI controls from the dialog

stevencohn · 2023-06-04T14:46:54Z

OneMore/Commands/Search/SearchDialog.resx

Is there a reason this file was touched? If not, please revert the changes.

stevencohn · 2023-06-04T14:47:49Z

OneMore/OneNote.cs

-		public bool FallThrough { get; set; }
+		//public string NotebookXml => GetAllPages(); //onenote.Windows.CurrentWindow?.CurrentNotebookId;
+
+        public XElement GetAllPages()


Should be moved down alphabetically amongst the methods below

stevencohn · 2023-06-04T14:48:46Z

OneMore/OneNote.cs

+        {
+            onenote.GetHierarchy(null, HierarchyScope.hsPages, out string xml, XMLSchema.xs2013);
+            if (!string.IsNullOrEmpty(xml))
+            {


There's not a lot of value in this helper function beyond what GetHierarchy already provides. I'd suggest just inlining it within your business logic rather than adding to the OneNote class.

stevencohn · 2023-06-04T14:49:52Z

OneMore/OneNote.cs

+        /// <returns></returns>
+        public async Task MovedAfterPage(string CurPageId, string DestPageId)
+        {
+            var root = GetAllPages();


This is very inefficient. There are easier ways of discovering, tracking, and using the notebook and section IDs along with the page and target IDs to make this faster.

stevencohn · 2023-06-04T14:51:06Z

OneMore/Properties/Resources.ar-SA.resx

@@ -3446,6 +3446,10 @@ ISO-code then comma then language name</comment>
    <value>بحث ونسخ / نقل</value>
    <comment>ribbon item</comment>
  </data>
+  <data name="ribNaviButton_Label" xml:space="preserve">
+    <value>FastNavi</value>


Is there a better name than "FastNavi"?

Will fix it. How about "Incremental Search"?

stevencohn · 2023-06-04T14:54:18Z

OneMore/Commands/Navigator/NaviPages.cs

+                    FilteredPageXml = FilterXml(AllPageXML, strKeyWords);
+                }
+
+                hierarchyView11.Nodes.Clear();


This is a poor use of TreeView, causing flickering and slowness with each keystroke. You also don't need to fetch AllPages on every keystroke since it is unlikely the hierarchy would change while this dialog is open.

This is a poor use of TreeView, causing flickering and slowness with each keystroke. You also don't need to fetch AllPages on every keystroke since it is unlikely the hierarchy would change while this dialog is open.

It seems that this variable AllPageXML is passed by reference, not by value.
If the value is not fetched very loop, its value will be changed by the function FilterXML.
I've tried to define a class with a copy element, but still no luck here.
As for the flickering, I trid serveral methods, also no luck.
Could you give any comments on how to solve those two problems? Thanks.

stevencohn · 2023-06-04T16:29:23Z

Honestly, I'm trying to understand where this really belongs. It's functionally equivalent to Search/SearchDialog but with type-ahead, which I'm not sure is enough of a reason for a new dialog.

What do you see as the primary difference?

valuex · 2023-06-05T12:05:39Z

Honestly, I'm trying to understand where this really belongs. It's functionally equivalent to Search/SearchDialog but with type-ahead, which I'm not sure is enough of a reason for a new dialog.

What do you see as the primary difference?
One of great things of OneMore is that it not only provides plenty of wonderful features, but also provide a good foundation for the beginners to develop their needed feature for OneNote.
The reason I develop this is that for a keyboard guy (who perfers inputting by keyboard to mouse), incremental search is definitely with higher efficiency. And also as a Chinese, incremental search by PinYin is far more effcient.
As you can tell, my coding skill is just the entry-level. And I really appreciate your patience and nice comment here.

jasonjac2 · 2023-06-05T13:53:57Z

@valuex your streaks ahead of me on it though. I like incremental searches. I didn't realise the power of the exisitng Search & copy Move. I would put your tool in "navigate" is navigate became tabbed with hotkeys for move between them. I would probably put Fav / Nav / Incremental all on a dockable form and be able to turn tabs on / off with preferences.

... But at the moment I would put it on its own "experimental" tabbed form, then we can have stuff that isn't completely baked in and not spend too long on consistency while we work out if it is gold or "may be a good idea".

valuex added 4 commits June 4, 2023 00:29

add FastNavi

2aa17a3

Add FastNavi

e774ef9

Merge branch 'master' of https://github.com/valuex/OneMore

5552d8e

Navigate by Incremental Search

8d2385b

stevencohn requested changes Jun 4, 2023

View reviewed changes

valuex added 2 commits June 6, 2023 00:16

Delete NaviDialog.cs

b67aec7

Delete NaviDialog.Designer.cs

f25f1df

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a command to navigate to a certain page by incremental search #1044

Add a command to navigate to a certain page by incremental search #1044

valuex commented Jun 4, 2023

stevencohn Jun 4, 2023

stevencohn Jun 4, 2023

stevencohn Jun 4, 2023

stevencohn Jun 4, 2023

stevencohn Jun 4, 2023

stevencohn Jun 4, 2023

valuex Jun 5, 2023

stevencohn Jun 4, 2023

valuex Jun 5, 2023

stevencohn commented Jun 4, 2023

valuex commented Jun 5, 2023

jasonjac2 commented Jun 5, 2023

Add a command to navigate to a certain page by incremental search #1044

Are you sure you want to change the base?

Add a command to navigate to a certain page by incremental search #1044

Conversation

valuex commented Jun 4, 2023

IS YOUR COMMIT SIGNED?

Enhancement or Defect Addressed by This PR

Description of Proposed Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevencohn commented Jun 4, 2023

valuex commented Jun 5, 2023

jasonjac2 commented Jun 5, 2023