Fix: Form Control and content not reflecting any changes when pasting text
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bampakoa
reviewed
Aug 2, 2024
Co-authored-by: Aristeidis Bampakos <[email protected]>
|
|
@behdi sorry for the delay in merge |
|
@stevermeister It may be a bit of a tall ask, but is it possible to backport this fix to v17 as well? Since this issue was introduced there as well. |
|
@behdi good point! |
|
published [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed an issue where pasting text inside the editor's text box would not update the form control value or cause
contentChangeto emit a value.The issue seems to stem from the fact that anytime a paste event happens, we call
event.preventDefault, and then we modify the html nodes, which causes zone.js to not pick up any of the added changes, until we actually manually add more content by typing into the text box.Take a look at the issue for more info #211.