-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uninstall.sh #164
base: master
Are you sure you want to change the base?
Update uninstall.sh #164
Conversation
as part of the uninstall during canary i dont think we care about the rest of the manual cleanup all we care is if mch is deleted successfully if mch delete hangs (with some timeout set) than we fail the testcase and move on |
any forward movement with this PR? |
Uninstall script has been added, watch of mch status and supplemental code paths need to be added to canary & canary-scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, LGTM!
7d04589
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, LGTM!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kyl-Bempah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kyl-Bempah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if [[ "$DEBUG" == "true" ]]; then | ||
echo "#####" | ||
component_list=$(oc get multiclusterobservability --all-namespaces -o json | jq -r '.items[].status.components') | ||
printf "%-30s\t%-10s\t%-30s\t%-30s\n" "COMPONENT" "STATUS" "TYPE" "REASON" | ||
for status_item in $(echo $component_list | jq -r 'keys | .[]'); do | ||
component=$(echo $component_list | jq -r --arg ITEM_NAME "$status_item" '.[$ITEM_NAME]') | ||
component_status="$(echo $component | jq -r '.status')"; | ||
type="$(echo $component | jq -r '.type')"; | ||
reason="$(echo $component | jq -r '.reason')"; | ||
message="$(echo $component | jq -r '.message')"; | ||
printf "%-30s\t%-10s\t%-30s\t%-30s\n" "$status_item" "$component_status" "$type" "$reason" | ||
done | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesnt work for obs so lets remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does observability not have components we can watch be torn down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not check their schema
acc=0 | ||
while [[ $(oc get multiclusterobservability --all-namespaces) && $acc -le $POLL_DURATION_21X ]]; do | ||
curr_status=$(oc get multiclusterobservability --all-namespaces -o json | jq -r '.items[].status.phase') 2> /dev/null | ||
echo "Waited $acc/$POLL_DURATION_21X seconds for MCO to be deleted. Current Status: $curr_status" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indention
@Kyl-Bempah: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR made for https://github.com/open-cluster-management/backlog/issues/6177, need to finish editing script.