Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Support statsJson in angular schemas #29233

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Sep 27, 2024

Closes #

What I did

this PR introduced the flag and added handling of statsJson in angular, but an important piece was missing: to update the angular schema to include that flag as well. This PR introduces it.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 0 B 1.24 0%
initSize 143 MB 143 MB 0 B -0.73 0%
diffSize 65.1 MB 65.1 MB 0 B -0.73 0%
buildSize 6.87 MB 6.87 MB 0 B 0.82 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B 0.75 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.9 MB 0 B 0.82 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB 0 B 0.82 0%
buildPreviewSize 3 MB 3 MB 0 B - 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 7.4s 7.1s -317ms -0.9 -4.5%
generateTime 23.2s 21.1s -2s -143ms -0.61 -10.1%
initTime 16.6s 16.2s -412ms 0.19 -2.5%
buildTime 8.5s 7.8s -688ms -1.53 🔰-8.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.4s 5.7s -718ms -0.9 -12.5%
devManagerResponsive 4.2s 3.5s -690ms -1.08 -19.6%
devManagerHeaderVisible 858ms 651ms -207ms -0.02 -31.8%
devManagerIndexVisible 948ms 681ms -267ms -0.29 -39.2%
devStoryVisibleUncached 1.1s 913ms -258ms -0.74 -28.3%
devStoryVisible 895ms 680ms -215ms -0.23 -31.6%
devAutodocsVisible 607ms 559ms -48ms -0.3 -8.6%
devMDXVisible 723ms 549ms -174ms -0.33 -31.7%
buildManagerHeaderVisible 652ms 574ms -78ms -0.48 -13.6%
buildManagerIndexVisible 656ms 585ms -71ms -0.53 -12.1%
buildStoryVisible 654ms 567ms -87ms -0.53 -15.3%
buildAutodocsVisible 501ms 441ms -60ms -1.02 -13.6%
buildMDXVisible 517ms 471ms -46ms -0.53 -9.8%

Greptile Summary

This PR adds support for the 'statsJson' option in Angular's build-storybook and start-storybook schemas, enhancing configuration options for Storybook in Angular projects.

  • Added 'statsJson' property to /code/frameworks/angular/src/builders/build-storybook/schema.json
  • Added 'statsJson' property to /code/frameworks/angular/src/builders/start-storybook/schema.json
  • Both schemas now support writing stats JSON to disk, similar to existing 'webpackStatsJson' option
  • Improves flexibility in output generation for Angular projects using Storybook

@yannbf yannbf added bug angular patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Sep 27, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Sep 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 30293dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants