safer and fail-faster reading of bogus frames #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I created #196 I noticed that when enabling
-race
for travis, the build would just "explode" with a silent:When I analysed it locally, I discovered that TestGoFuzzCrashers was actually taking up several GBs of ram just to run 3 fuzzed strings against
ReadFrame
, because one of the test cases were actually telling it to allocate like 4GB+ of data.This is my attempt to change all calls to ReadFull (that could be manipulated by a malicious user) with buffered-reading into a bytes.Buffer-backed buffer (which will grow for every successful read). This has the advantage of failing faster if a frame has a fake length in it. I just placed a 1MB threshold, since I believe most real-world cases will fit that size.
Also, there were some cases with negative lengths that were not being covered and were detected using go-fuzz.
Please let me know what you think.