Increase timeouts in Test_Mock_Called_blocks to reduce flakiness in CI #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brackendawson
approved these changes
Oct 28, 2024
Thanks for the oppurtunity:) Lmk if you'd want me to work on any other issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increased timeouts in the
Test_Mock_Called_blockstest to improve stability and reduce flakiness in CI environments.Changes
selectblock from1msto10msto allow more time before checking for the channel.Afterclause in the mocked service'sasyncCallfrom2msto20msto ensure sufficient time for the asynchronous operation to complete.Motivation
The changes were necessary to address intermittent test failures caused by tight timing constraints in low-powered CI environments. By increasing the timeouts, we aim to enhance the reliability of our tests, ensuring they pass consistently across different execution environments.
Related issues
Closes #1666