Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the generic title "Front of identity document" instead of "Front of identity card" #9188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

googol7
Copy link

@googol7 googol7 commented Sep 4, 2024

See #8511

This change is similar to:

Summary

Motivation

Because currently the title is always "Front of identity card" regardless of what is configured in options.document.allowed_types, users upload their "Identity card" (German: "Personalausweis") instead of the "Driver's license" (German: Führerschein"). So the more generic term "Identity document" should be used. This approach was also changed recently in stripe-ios here.

The optimal solution would be that the title corresponds exactly with options.document.allowed_types. This is how the web version already does it.

Example:

options.document.allowed_types string used
["driving_license"] <string name="stripe_front_of_dl">Front of driver\'s license</string>
["id_card"] <string name="stripe_front_of_id">Front of identity card</string>
["passport"] <string name="stripe_passport">Passport</string>
["driving_license", "id_card", "passport"] <string name="stripe_front_of_id_document">Front of identity document</string>

I've seen that with this commit in the PR

these new translations were added:

<string name="stripe_front_of_id_document">Front of identity document</string>
<string name="stripe_back_of_id_document">Back of identity document</string>

but they are not used in the code yet.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@googol7 googol7 requested review from a team as code owners September 4, 2024 19:47
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

@googol7
Copy link
Author

googol7 commented Oct 28, 2024

@aywang-stripe @awush-stripe We have verification sessions every day, where users upload the front side of their driver's license, but upload the backside of their ID card (German: "Personalausweis") because these titles are wrong. We need the backside of the driver's license.

The Stripe support wrote:

I wanted to provide you with some clarification regarding our ID verification process. We still consider the front side of the document if it is recognized as a driver's license, especially if we are unable to extract clear information from the back of these IDs. In such cases, we will trust the data provided on the front of the IDs.

Additionally, the Stripe Identity team has informed us that there are currently no immediate plans to work on a feature that would allow us to also consider the back of the IDs during the verification process.

We apologize for the inconvenience this may have caused. If you have any further questions or concerns, please feel free to reach out.

@googol7
Copy link
Author

googol7 commented Nov 14, 2024

@aywang-stripe @awush-stripe Thanks for approving this PR. Does it need some more approval? When do you expect it to be merged? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants