Update to compose 1.7.4. #9511

jaynewstrom-stripe · 2024-10-24T13:13:14Z

Summary

Updates compose from 1.6.8 to 1.7.4.

github-actions · 2024-10-24T13:13:29Z

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

github-actions · 2024-10-24T13:19:32Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed            
          ├───────────┬───────────┬──────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff      
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
      dex │     4 MiB │     4 MiB │ +6.2 KiB │   8.8 MiB │   8.8 MiB │ +13.3 KiB 
     arsc │   2.3 MiB │   2.3 MiB │   -128 B │   2.3 MiB │   2.3 MiB │    -128 B 
 manifest │     5 KiB │     5 KiB │      0 B │    25 KiB │    25 KiB │       0 B 
      res │ 932.6 KiB │ 932.6 KiB │      0 B │   1.5 MiB │   1.5 MiB │       0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │       0 B 
    asset │   2.9 MiB │   2.9 MiB │    +66 B │   2.9 MiB │   2.9 MiB │     +66 B 
    other │ 201.2 KiB │ 201.1 KiB │    -32 B │ 443.1 KiB │ 443.1 KiB │       0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
    total │    13 MiB │    13 MiB │ +6.1 KiB │    22 MiB │    22 MiB │ +13.3 KiB 

 DEX     │ old   │ new   │ diff               
─────────┼───────┼───────┼────────────────────
   files │     1 │     1 │    0               
 strings │ 42172 │ 42226 │  +54 (+155 -101)   
   types │ 14337 │ 14364 │  +27 (+87 -60)     
 classes │ 11948 │ 11975 │  +27 (+51 -24)     
 methods │ 61597 │ 61717 │ +120 (+6794 -6674) 
  fields │ 40433 │ 40545 │ +112 (+4678 -4566) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  242 │  242 │  0         
 entries │ 6271 │ 6269 │ -2 (+0 -2)

APK

     compressed      │     uncompressed      │                                
──────────┬──────────┼───────────┬───────────┤                                
 size     │ diff     │ size      │ diff      │ path                           
──────────┼──────────┼───────────┼───────────┼────────────────────────────────
    4 MiB │ +6.2 KiB │   8.8 MiB │ +13.3 KiB │ ∆ classes.dex                  
  2.3 MiB │   -128 B │   2.3 MiB │    -128 B │ ∆ resources.arsc               
  8.2 KiB │    +55 B │     8 KiB │     +55 B │ ∆ assets/dexopt/baseline.prof  
 50.4 KiB │    -45 B │ 118.9 KiB │       0 B │ ∆ META-INF/MANIFEST.MF         
 53.7 KiB │    +12 B │   119 KiB │       0 B │ ∆ META-INF/CERT.SF             
    1 KiB │    +11 B │     924 B │     +11 B │ ∆ assets/dexopt/baseline.profm 
  1.2 KiB │     +1 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA            
──────────┼──────────┼───────────┼───────────┼────────────────────────────────
  6.5 MiB │ +6.1 KiB │  11.4 MiB │ +13.3 KiB │ (total)

DEX

STRINGS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   42172 │ 42226 │ +54 (+155 -101) 
  
  +  DefaultValue: null
  +  instead of 
  + " for destination 
  + ([^/]*?|)
  + , animationSpec: 
  + , animationSpecDuration: 
  + , durationNanos: 
  + , fadeOutSpec=
  + , initialVelocity: 
  + , isComplete: 
  + , new instance: 
  + , placementSpec=
  + , rippleAlpha=
  + , start: 
  + , value: 
  + . Following required arguments are missing: 
  + . Missing required arguments [
  + An instance of SeekableTransitionState has been used in different Transitions. Previous instance: 
  + Anchored drag finished
  + Cannot navigate to startDestination 
  + Cannot set route "
  + Cannot transition entry that is not in the back stack
  + Expecting fraction between 0 and 1. Got 
  + LA2/M;
  + LA2/N;
  + LA2/O;
  + LA2/P;
  + LA2/Q;
  + LA2/S;
  + LFFFFFLII
  + LFFLLLI
  + LH1/H;
  + LJJJLII
  + LLLLZLII
  + LM1/o;
  + LP0/Y;
  + LR4/g;
  + LW9/i0;
  + LW9/j0;
  + LW9/k0;
  + LW9/l0;
  + LY/b0;
  + LZ/A0;
  + LZ/B0;
  + LZ/C0;
  + LZ/D0;
  + LZ/E0;
  + LZ/F0;
  + LZ/G0;
  + LZ/H0;
  + LZ/w0;
  + LZ/x0;
  + LZ/y0;
  + LZ/z0;
  + La0/F0;
  + Landroidx/compose/material/DraggableAnchorsElement;
  + Landroidx/compose/material/a;
  + Landroidx/recyclerview/widget/G0;
  + LazyLayoutAnimateItemElement(fadeInSpec=
  + Lc/i;
  + Lc/j;
  + Lc/k;
  + Lc/l;
  + Lc/m;
  + Ld0/n;
  + Lg0/f0;
  + Lg0/g0;
  + Lg0/h0;
  + Lg5/b;
  + Lg5/c;
  + Lu5/i;
  + Lv0/A;
  + Lv0/B;
  + Lv0/C;
  + Lv0/D;
  + Lv0/E;
  + Lz2/K;
  + Lz2/L;
  + Lz2/M;
  + Navigation destination that matches route 
  + ReceiveChannel.consumeAsFlow can be collected just once
  + RippleConfiguration(color=
  + VLFLLLZLL
  + VLLFL
  + VLLLIZLLL
  + VLLLLFL
  + VLLLLLLLLLII
  + VLLLLLLLLLLLII
  + VLLLLLLLLLLLLII
  + VLLLLLLLLZZZLLLLLII
  + VLLLLLLLLZZZLLLLLLII
  + VLLLLLLZFLI
  + VLLLLLLZFLLI
  + VLLLLLLZFLLLII
  + VLLLLLLZFLLLLII
  + VLLLLZZLLLLLLZLZL
  + VLLLZZLLZLLLLLLLIII
  + VLLLZZLLZLLLLLLLLII
  + VLLZZLLZLLLLLLLLIII
  + VLLZZLLZLLLLLLLLLII
  + VLZFLL
  + VLZLIL
  + VLZLJLJJFLL
  + VLZZLLLFFI
  + VLZZLLZLLLLLLI
  + VZFJ
  + VZILLLLLLI
  + VZZLLLFFLI
  + You must collect the progress flow
  + [LC6/s;
  + [LE6/i;
  + [LG0/v;
  + [LG0/w;
  + [LG6/I;
  + [LG6/W;
  + [LG6/y;
  + [LW9/X;
  + [LW9/Y;
  + [LW9/k0;
  + [LY/C;
  + [La0/j0;
  + [Landroidx/recyclerview/widget/E0;
  + [Landroidx/recyclerview/widget/I;
  + [Landroidx/recyclerview/widget/T;
  + [Landroidx/recyclerview/widget/p0;
  + [Lf1/Q;
  + [Lf7/f2;
  + [Lf7/j2;
  + [Lf7/l2;
  + [Lf8/S1;
  + [Lf8/u0;
  + [Lg0/B;
  + [Lg0/T;
  + [Lg0/d0;
  + [Lg7/f;
  + [Lk0/P;
  + [Lp0/B1;
  + [Lp0/N0;
  + [Lp0/d1;
  + [Lp0/g2;
  + [Lp0/r3;
  + [Lu5/f;
  + [Lw1/C;
  + [Lw1/o;
  + [Lz2/L;
  + deepLink
  + inputParams
  + layoutlib
  + onBack cancelled
  + progress nanos: 
  + snapTo() was canceled because state was changed to 
  + targetState while waiting for composition
  + try {
                    …tring()
                  }
  + uriPattern
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"f473302","r8-mode":"full","version":"8.7.14"}
  
  - ) was not set. Did you use ModalBottomSheetState with the ModalBottomSheetLayout composable?
  - , fadeOutSpec=null)
  - FFFL
  - LC1/b;
  - LC6/N;
  - LE6/l;
  - LE6/m;
  - LFFFFFLI
  - LFLI
  - LG0/H;
  - LG0/I;
  - LG0/J;
  - LG0/K;
  - LG0/L;
  - LG0/M;
  - LG6/d0;
  - LI9/f;
  - LJJJLI
  - LLLLZLI
  - LN/n;
  - LazyLayoutAnimateItemElement(fadeInSpec=null, placementSpec=
  - Lb0/r;
  - Lf1/d0;
  - Lf8/W1;
  - Lg7/p;
  - Lg7/q;
  - Lk0/N0;
  - Lp0/y3;
  - Lw1/J;
  - Lz0/c;
  - Lz0/d;
  - Lz0/e;
  - Navigation destination that matches request 
  - SnapshotStateMap(value=
  - The density on ModalBottomSheetState (
  - VILIILI
  - VJIJF
  - VLFLZLLLL
  - VLLFI
  - VLLLIZLLLI
  - VLLLLIIZLIJLL
  - VLLLLLLLLLLLI
  - VLLLLLLLLZZZLLLLIII
  - VLLLLLLLLZZZLLLLLIII
  - VLLLLLZFLLLII
  - VLLLLLZFLLLLII
  - VLLLLZZLLLLLZLZL
  - VLLLZZLLZLLLLLLIII
  - VLLLZZLLZLLLLLLLII
  - VLLZZLLZLLLLLLLIII
  - VLLZZLLZLLLLLLLLII
  - VLZJLJJFLLL
  - VLZZLLLFFII
  - VLZZLLZLLLLL
  - VLZZZZ
  - VZFLL
  - VZILLLLLLII
  - VZLLJJFLJLL
  - VZZLLLFFLII
  - [LC6/t;
  - [LE6/k;
  - [LG0/A;
  - [LG0/z;
  - [LG6/A;
  - [LG6/O;
  - [LG6/Z;
  - [LW9/U;
  - [LW9/V;
  - [LW9/e0;
  - [LY/B;
  - [La0/i0;
  - [Landroidx/recyclerview/widget/C0;
  - [Landroidx/recyclerview/widget/H;
  - [Landroidx/recyclerview/widget/S;
  - [Landroidx/recyclerview/widget/o0;
  - 
...✂

ARSC

ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6271 │ 6269 │ -2 (+0 -2) 
  - style/FloatingDialogTheme
  - style/FloatingDialogWindowTheme

emerge-tools · 2024-10-24T14:16:19Z

3 builds increased size

Name	Version	Download	Change	Install	Change	Approval
⚠️ Stripe Identity Example com.stripe.android.identity.example.theme1	20.53.0-theme1 (20)	3.9 MB	⬆️ 105.8 kB (2.78%)	9.2 MB	⬆️ 226.5 kB (2.53%)	N/A
⚠️ Financial Connections Example com.stripe.android.financialconnections.example	20.53.0 (205300)	4.3 MB	⬆️ 118.8 kB (2.83%)	9.6 MB	⬆️ 253.8 kB (2.71%)	N/A
PaymentSheet Example com.stripe.android.paymentsheet.example	20.53.0 (11)	8.6 MB	⬆️ 6.2 kB (0.07%)	16.3 MB	⬆️ 13.6 kB (0.08%)	N/A

Stripe Identity Example 20.53.0-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 226.5 kB (2.53%)
Total download size change: ⬆️ 105.8 kB (2.78%)

Largest size changes

Item	Install Size Change	Download Size Change
androidx.camera.core.impl.utils.executor.MainThreadExecutor	⬇️ -29.6 kB	⬇️ -14.2 kB
📝 androidx.compose.ui.focus.FocusInteropUtils	⬆️ 29.2 kB	⬆️ 14.1 kB
🗑 androidx.compose.ui.Modifier$-CC	⬇️ -27.2 kB	⬇️ -13.1 kB
androidx.camera.core.impl.utils.MainThreadAsyncHandler	⬇️ -27.1 kB	⬇️ -13.0 kB
🗑 androidx.compose.ui.node.IntrinsicsPolicy	⬇️ -26.8 kB	⬇️ -12.9 kB

View Treemap

Financial Connections Example 20.53.0 (205300)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 253.8 kB (2.71%)
Total download size change: ⬆️ 118.8 kB (2.83%)

Largest size changes

Item	Install Size Change	Download Size Change
📝 kotlin.text.CharsKt	⬆️ 47.6 kB	⬆️ 22.4 kB
📝 com.google.android.instantapps.InstantApps	⬆️ 43.4 kB	⬆️ 20.4 kB
🗑 com.stripe.android.cards.Cvc	⬇️ -41.5 kB	⬇️ -19.6 kB
🗑 com.stripe.android.financialconnections.features.manualentrysucce...	⬇️ -39.6 kB	⬇️ -18.7 kB
📝 androidx.room.util.CursorUtil	⬆️ 37.8 kB	⬆️ 17.8 kB

View Treemap

PaymentSheet Example 20.53.0 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 13.6 kB (0.08%)
Total download size change: ⬆️ 6.2 kB (0.07%)

Largest size changes

Item	Install Size Change	Download Size Change
androidx.camera.core.AspectRatio	⬇️ -50.8 kB	⬇️ -23.2 kB
📝 com.nimbusds.jose.shaded.asm.DefaultConverter	⬆️ 50.7 kB	⬆️ 23.2 kB
androidx.transition.FragmentTransitionSupport$1	⬇️ -40.6 kB	⬇️ -18.5 kB
kotlin.collections.SetsKt	⬆️ 38.7 kB	⬆️ 17.7 kB
kotlin.collections.MapsKt__MapsKt	⬇️ -34.5 kB	⬇️ -15.8 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

jaynewstrom-stripe · 2024-10-24T14:44:44Z

I think everything is ready to go here, outside of an issue with our tests, see:

jaynewstrom-stripe added the accept-risky-change accept-risky-change label Oct 24, 2024

jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4 branch 2 times, most recently from 62586d9 to f3640dc Compare October 24, 2024 14:12

jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4 branch from f3640dc to b502910 Compare October 24, 2024 19:29

jaynewstrom-stripe added 3 commits October 26, 2024 06:16

Update to compose 1.7.4.

d023844

Update dependency baseline.

e2bb80d

Update screenshots.

58b0311

jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4 branch from b502910 to 58b0311 Compare October 26, 2024 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to compose 1.7.4. #9511

Update to compose 1.7.4. #9511

jaynewstrom-stripe commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 •

edited

Loading

emerge-tools bot commented Oct 24, 2024 •

edited

Loading

jaynewstrom-stripe commented Oct 24, 2024

Update to compose 1.7.4. #9511

Are you sure you want to change the base?

Update to compose 1.7.4. #9511

Conversation

jaynewstrom-stripe commented Oct 24, 2024 • edited Loading

Summary

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 • edited Loading

emerge-tools bot commented Oct 24, 2024 • edited Loading

3 builds increased size

Stripe Identity Example 20.53.0-theme1 (20)com.stripe.android.identity.example.theme1

Financial Connections Example 20.53.0 (205300)com.stripe.android.financialconnections.example

PaymentSheet Example 20.53.0 (11)com.stripe.android.paymentsheet.example

jaynewstrom-stripe commented Oct 24, 2024

jaynewstrom-stripe commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

emerge-tools bot commented Oct 24, 2024 •

edited

Loading

Stripe Identity Example 20.53.0-theme1 (20)
com.stripe.android.identity.example.theme1

Financial Connections Example 20.53.0 (205300)
com.stripe.android.financialconnections.example

PaymentSheet Example 20.53.0 (11)
com.stripe.android.paymentsheet.example