-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PaymentMethodRowButton to support embedded configurations #9596
base: master
Are you sure you want to change the base?
Conversation
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this a different way (any of these work for me):
- We should separate the shell from the content in a pure refactor, no new functionality. Just enabling the inner content to be used by some different outer content later on.
- We should merge in the appearance API first, then make these changes.
I don't love having half baked code in the repo (TODOs aren't tracked anywhere!).
We also have a lot of opportunity to add screenshot tests here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this centered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this full screen?
Summary
Refactor
PaymentMethodRowButton
to support embedded configurations.Notes:
Motivation
MOBILESDK-2626
Testing