Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag and LinkConsumerIncentive struct #9605

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │ +1.2 KiB │   8.4 MiB │   8.4 MiB │ +2.3 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │     5 KiB │     5 KiB │      0 B │  24.9 KiB │  24.9 KiB │      0 B 
      res │ 902.3 KiB │ 902.3 KiB │      0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │    -17 B │   1.6 MiB │   1.6 MiB │    -17 B 
    other │ 199.8 KiB │ 199.8 KiB │     +1 B │ 440.1 KiB │ 440.1 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  11.4 MiB │  11.4 MiB │ +1.2 KiB │  20.2 MiB │  20.2 MiB │ +2.3 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 39812 │ 39829 │ +17 (+74 -57)     
   types │ 13732 │ 13736 │  +4 (+60 -56)     
 classes │ 11424 │ 11426 │  +2 (+10 -8)      
 methods │ 58669 │ 58684 │ +15 (+2188 -2173) 
  fields │ 38983 │ 38993 │ +10 (+1422 -1412) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6190 │ 6190 │  0
APK
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  3.9 MiB │ +1.2 KiB │   8.4 MiB │ +2.3 KiB │ ∆ classes.dex                  
  7.8 KiB │    -10 B │   7.7 KiB │    -10 B │ ∆ assets/dexopt/baseline.prof  
  1,019 B │     -7 B │     887 B │     -7 B │ ∆ assets/dexopt/baseline.profm 
 49.8 KiB │     +4 B │ 117.5 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
   53 KiB │     -3 B │ 117.6 KiB │      0 B │ ∆ META-INF/CERT.SF             
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
    4 MiB │ +1.2 KiB │   8.7 MiB │ +2.3 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   39812 │ 39829 │ +17 (+74 -57) 
  
  + , amountPercent=
  + , incentiveParams=
  + , linkConsumerIncentive=
  + IBP Incentives
  + IncentiveParams(amountFlat=
  + LI6/j3;
  + LI6/k3;
  + LK6/j;
  + LP8/p;
  + LR4/b;
  + LT6/r;
  + LV5/Z2;
  + Le6/u;
  + LinkConsumerIncentive(campaign=
  + Ll6/G;
  + Lq2/d;
  + [LI6/B2;
  + [LI6/K0;
  + [LI6/P0;
  + [LI6/P2;
  + [LI6/R1;
  + [LI6/U0;
  + [LI6/U1;
  + [LI6/U2;
  + [LI6/X1;
  + [LI6/Y0;
  + [LI6/Z2;
  + [LI6/a3;
  + [LI6/f1;
  + [LI6/j3;
  + [LI6/k3;
  + [LI6/m1;
  + [LI6/s1;
  + [LI6/z2;
  + [LK6/i;
  + [LL7/E;
  + [LL7/M;
  + [LL7/b;
  + [LL7/y;
  + [LQ5/b;
  + [LQ5/h;
  + [LR4/b;
  + [LR8/E;
  + [LR8/N;
  + [LR8/d0;
  + [LR8/d;
  + [LR8/f0;
  + [LR8/j;
  + [LR8/p0;
  + [LR8/x;
  + [LT6/q;
  + [LU5/b;
  + [LU5/e;
  + [LU5/i;
  + [LU5/m;
  + [LV5/Z2;
  + [LV5/e0;
  + [LV5/h0;
  + [LV7/e;
  + [LV7/j;
  + [LZ7/L;
  + [Lb6/I;
  + [Le6/t;
  + [Le8/l;
  + [Ll6/A;
  + [Ll6/t;
  + amount_flat
  + amount_percent
  + campaign
  + incentiveParams
  + incentive_params
  + link_consumer_incentive
  + optDouble
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"0c5bf70","r8-mode":"full","version":"8.7.14"}
  
  - LL7/V;
  - LQ5/q;
  - LR8/s0;
  - LU5/o;
  - LV7/k;
  - Le8/t;
  - Lm2/d;
  - Lr0/i;
  - [LI6/A2;
  - [LI6/C2;
  - [LI6/M0;
  - [LI6/R0;
  - [LI6/R2;
  - [LI6/T1;
  - [LI6/W0;
  - [LI6/W1;
  - [LI6/W2;
  - [LI6/Z1;
  - [LI6/a1;
  - [LI6/d3;
  - [LI6/e3;
  - [LI6/g1;
  - [LI6/o1;
  - [LI6/u1;
  - [LK6/f;
  - [LL7/D;
  - [LL7/F;
  - [LL7/N;
  - [LL7/d;
  - [LQ5/g;
  - [LQ5/i;
  - [LR4/a;
  - [LR8/F;
  - [LR8/O;
  - [LR8/e0;
  - [LR8/e;
  - [LR8/g0;
  - [LR8/l;
  - [LR8/q0;
  - [LR8/y;
  - [LT6/p;
  - [LU5/d;
  - [LU5/h;
  - [LU5/l;
  - [LU5/o;
  - [LV5/Y2;
  - [LV5/d0;
  - [LV5/g0;
  - [LV7/i;
  - [LV7/k;
  - [LZ7/J;
  - [Lb6/G;
  - [Le6/s;
  - [Le8/o;
  - [Ll6/s;
  - [Ll6/z;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"9247d1a","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   13732 │ 13736 │ +4 (+60 -56) 
  
  + LI6/j3;
  + LI6/k3;
  + LK6/j;
  + LP8/p;
  + LR4/b;
  + LT6/r;
  + LV5/Z2;
  + Le6/u;
  + Ll6/G;
  + Lq2/d;
  + [LI6/B2;
  + [LI6/K0;
  + [LI6/P0;
  + [LI6/P2;
  + [LI6/R1;
  + [LI6/U0;
  + [LI6/U1;
  + [LI6/U2;
  + [LI6/X1;
  + [LI6/Y0;
  + [LI6/Z2;
  + [LI6/a3;
  + [LI6/f1;
  + [LI6/j3;
  + [LI6/k3;
  + [LI6/m1;
  + [LI6/s1;
  + [LI6/z2;
  + [LK6/i;
  + [LL7/E;
  + [LL7/M;
  + [LL7/b;
  + [LL7/y;
  + [LQ5/b;
  + [LQ5/h;
  + [LR4/b;
  + [LR8/E;
  + [LR8/N;
  + [LR8/d0;
  + [LR8/d;
  + [LR8/f0;
  + [LR8/j;
  + [LR8/p0;
  + [LR8/x;
  + [LT6/q;
  + [LU5/b;
  + [LU5/e;
  + [LU5/i;
  + [LU5/m;
  + [LV5/Z2;
  + [LV5/e0;
  + [LV5/h0;
  + [LV7/e;
  + [LV7/j;
  + [LZ7/L;
  + [Lb6/I;
  + [Le6/t;
  + [Le8/l;
  + [Ll6/A;
  + [Ll6/t;
  
  - LL7/V;
  - LQ5/q;
  - LR8/s0;
  - LU5/o;
  - LV7/k;
  - Le8/t;
  - Lm2/d;
  - Lr0/i;
  - [LI6/A2;
  - [LI6/C2;
  - [LI6/M0;
  - [LI6/R0;
  - [LI6/R2;
  - [LI6/T1;
  - [LI6/W0;
  - [LI6/W1;
  - [LI6/W2;
  - [LI6/Z1;
  - [LI6/a1;
  - [LI6/d3;
  - [LI6/e3;
  - [LI6/g1;
  - [LI6/o1;
  - [LI6/u1;
  - [LK6/f;
  - [LL7/D;
  - [LL7/F;
  - [LL7/N;
  - [LL7/d;
  - [LQ5/g;
  - [LQ5/i;
  - [LR4/a;
  - [LR8/F;
  - [LR8/O;
  - [LR8/e0;
  - [LR8/e;
  - [LR8/g0;
  - [LR8/l;
  - [LR8/q0;
  - [LR8/y;
  - [LT6/p;
  - [LU5/d;
  - [LU5/h;
  - [LU5/l;
  - [LU5/o;
  - [LV5/Y2;
  - [LV5/d0;
  - [LV5/g0;
  - [LV7/i;
  - [LV7/k;
  - [LZ7/J;
  - [Lb6/G;
  - [Le6/s;
  - [Le8/o;
  - [Ll6/s;
  - [Ll6/z;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   58669 │ 58684 │ +15 (+2188 -2173) 
  
  + A4.c <init>(v1, m, p, t, f0)
  + B5.G <init>(c, String, t, a, p, a, int)
  + B5.I <init>(Parcelable, t, c, t, List, int)
  + B5.e0 <init>(G, q, F, boolean, c, int)
  + B5.i0 A(int, int) → int
  + B5.i0 B(h) → boolean
  + B5.i0 C(Boolean, String, boolean, f, boolean, List, I, a, a, boolean) → U
  + B5.i0 D(m, A1, e) → ArrayList
  + B5.i0 E(u, A1) → a
  + B5.i0 F(float[], float[]) → float
  + B5.i0 G(u, j, m, List, t) → List
  + B5.i0 H(u, j, m, List, boolean) → a
  + B5.i0 I(h) → Object
  + B5.i0 J(Context, int, int) → int
  + B5.i0 K(View, int) → int
  + B5.i0 L(int, Rect, Rect) → boolean
  + B5.i0 M(int) → boolean
  + B5.i0 N(C) → boolean
  + B5.i0 O(float, int, int) → int
  + B5.i0 P(
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-model-changes branch 2 times, most recently from 28c347f to 3a1b762 Compare November 13, 2024 21:12
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-model-changes branch from 3a1b762 to a53e7c3 Compare November 15, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant