-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Verification UI #9606
base: master
Are you sure you want to change the base?
Link Verification UI #9606
Conversation
Diffuse output:
APK
|
97ffbd7
to
770dc84
Compare
770dc84
to
dda5407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Enter your vertification code" text looks way bigger on these screenshots than on the screen recording you uploaded. Do you know why that is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because it's not wrapped with the correct theme. Just fixed it
listOf(SystemAppearance.DarkTheme), | ||
listOf(FontSize.DefaultFont) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend only including config options if you're going to list multiple options here -- otherwise, you can just leave them out and it'll default to our default settings
style = MaterialTheme.typography.body1, | ||
color = MaterialTheme.colors.onSecondary | ||
) | ||
DefaultStripeTheme { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity - why does this theme only apply to the otp element and not to the whole screen? Or why are we not using the link theme for this part of the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it because the old UI wrapped the component in this theme, but it looks like removing it doesn't change anything. I just took it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some UI tests for this screen? Generally we use compose rule to test behavior of our UIs
3bb8a02
to
2230a61
Compare
Summary
Native UI for verifying link account
Motivation
JIRA
Testing
Screenshots
382094464-20185f3d-1d48-485c-ba77-048123fde4bd.mov
Changelog