Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkAccount payment methods list #9616

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Nov 13, 2024

Summary

update link account manager to allow consumer payment methods to be fetched

Motivation

JIRA

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.9 MiB │   3.9 MiB │ +1 B │   8.4 MiB │   8.4 MiB │  0 B 
     arsc │   2.3 MiB │   2.3 MiB │  0 B │   2.3 MiB │   2.3 MiB │  0 B 
 manifest │     5 KiB │     5 KiB │  0 B │  24.9 KiB │  24.9 KiB │  0 B 
      res │ 902.3 KiB │ 902.3 KiB │  0 B │   1.4 MiB │   1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
    other │ 199.8 KiB │ 199.8 KiB │ +1 B │ 440.1 KiB │ 440.1 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.4 MiB │  11.4 MiB │ +2 B │  20.2 MiB │  20.2 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 39797 │ 39797 │ 0 (+1 -1) 
   types │ 13728 │ 13728 │ 0 (+0 -0) 
 classes │ 11422 │ 11422 │ 0 (+0 -0) 
 methods │ 58647 │ 58647 │ 0 (+0 -0) 
  fields │ 38976 │ 38976 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6190 │ 6190 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
    272 B │ +5 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 49.7 KiB │ -4 B │ 117.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
  3.9 MiB │ +1 B │   8.4 MiB │  0 B │ ∆ classes.dex                             
   53 KiB │ -1 B │ 117.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
    4 MiB │ +2 B │   8.6 MiB │  0 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   39797 │ 39797 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"c85bee3","r8-mode":"full","version":"8.7.14"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"5c6badc","r8-mode":"full","version":"8.7.14"}

@toluo-stripe toluo-stripe marked this pull request as ready for review November 13, 2024 19:04
@toluo-stripe toluo-stripe requested review from a team as code owners November 13, 2024 19:04
@@ -1435,6 +1437,27 @@ class StripeApiRepository @JvmOverloads internal constructor(
)
}

override suspend fun listPaymentDetails(
clientSecret: String,
paymentMethodTypes: Set<String>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this parameter needed? It looks like it's only set to emptySet and is otherwise unused (I could be missing something though)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. I was supposed to add it to the other interfaces as well. Just pushed a fix.

@toluo-stripe toluo-stripe merged commit 68c2a07 into master Nov 14, 2024
16 checks passed
@toluo-stripe toluo-stripe deleted the tolu/link_payment_list_repo branch November 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants