Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Link payment methods with Wallet VM #9630

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Nov 14, 2024

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.9 MiB │   3.9 MiB │ -1 B │   8.4 MiB │   8.4 MiB │  0 B 
     arsc │   2.3 MiB │   2.3 MiB │  0 B │   2.3 MiB │   2.3 MiB │  0 B 
 manifest │     5 KiB │     5 KiB │  0 B │  24.9 KiB │  24.9 KiB │  0 B 
      res │ 902.3 KiB │ 902.3 KiB │  0 B │   1.4 MiB │   1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │ +1 B │   1.6 MiB │   1.6 MiB │ +1 B 
    other │ 199.8 KiB │ 199.8 KiB │ +2 B │ 440.1 KiB │ 440.1 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.4 MiB │  11.4 MiB │ +2 B │  20.2 MiB │  20.2 MiB │ +1 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 39840 │ 39840 │ 0 (+1 -1) 
   types │ 13746 │ 13746 │ 0 (+0 -0) 
 classes │ 11438 │ 11438 │ 0 (+0 -0) 
 methods │ 58703 │ 58703 │ 0 (+0 -0) 
  fields │ 39014 │ 39014 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6190 │ 6190 │  0
APK
   compressed    │   uncompressed   │                               
──────────┬──────┼───────────┬──────┤                               
 size     │ diff │ size      │ diff │ path                          
──────────┼──────┼───────────┼──────┼───────────────────────────────
 49.7 KiB │ +4 B │ 117.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF        
   53 KiB │ -2 B │ 117.6 KiB │  0 B │ ∆ META-INF/CERT.SF            
  7.8 KiB │ +1 B │   7.7 KiB │ +1 B │ ∆ assets/dexopt/baseline.prof 
  3.9 MiB │ -1 B │   8.4 MiB │  0 B │ ∆ classes.dex                 
──────────┼──────┼───────────┼──────┼───────────────────────────────
    4 MiB │ +2 B │   8.7 MiB │ +1 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   39840 │ 39840 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"815bb1d","r8-mode":"full","version":"8.7.14"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"5b91f64","r8-mode":"full","version":"8.7.14"}

* The supported payment methods are read from [StripeIntent.linkFundingSources], and fallback to
* card only if the list is empty or none of them is valid.
*/
internal fun StripeIntent.supportedPaymentMethodTypes(linkAccount: LinkAccount) =
Copy link
Contributor Author

@toluo-stripe toluo-stripe Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obtained from here. SuppoertedPaymentMethod will be in this ticket .

@toluo-stripe toluo-stripe changed the title temp List payment methods for Link Nov 18, 2024
@toluo-stripe toluo-stripe changed the title List payment methods for Link WalletViewModel to list link payment methods Nov 18, 2024
@toluo-stripe toluo-stripe changed the title WalletViewModel to list link payment methods List Link payment methods with Wallet VM Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant