Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BANKCON-15001] Add telemetry fields to /share and /payment_methods API calls #4070

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

mats-stripe
Copy link
Collaborator

Summary

This adds telemetry (fraud detection) fields to the two payment method API calls; /share and /payment_methods. This uses the existing STPTelemetryClient to add these fields (muid, guid, and sid) to the request parameters.

Motivation

BANKCON-15001

Testing

(Hiding IDs here as to not expose anything)

Screenshot 2024-09-27 at 2 04 02 PM

Changelog

N/a

Copy link

github-actions bot commented Sep 27, 2024

🚨 New dead code detected in this PR:

{
  "FinancialConnectionsAPIClient.swift_sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:)": "FinancialConnectionsAPIClient.swift: warning: sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:) is unused",
  "EmptyFinancialConnectionsAPIClient.swift_sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:)": "EmptyFinancialConnectionsAPIClient.swift: warning: sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:) is unused"
}

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Base automatically changed from mats/call_share_endpoint_for_panther_payments to master September 30, 2024 18:40
@mats-stripe mats-stripe force-pushed the mats/add_telemetry_to_payment_method_api_calls branch from c675cd9 to 935e2a5 Compare September 30, 2024 19:54
@mats-stripe mats-stripe merged commit 04b1acf into master Oct 1, 2024
5 checks passed
@mats-stripe mats-stripe deleted the mats/add_telemetry_to_payment_method_api_calls branch October 1, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants