fix: Update FetchHttpClient to send empty string for empty POST/PUT/PATCH requests. #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-stripe
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @kamil-stripe
Summary
Updates the FetchHttpClient to explicitly send an empty string for methods which expect a payload but have no request data.
Motivation
#1519
Deno injects a second
Content-Lengthheader when we don't specify body explicitly (ie. pass a concrete value other than undefined), causing Stripe POST requests without bodies to fail. By passing an explicit body, this will no longer happen.Release plan
Publish this as a beta to validate the fix and then, if all looks good, roll it out to stable.