Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect key in param encoding #1488

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

helenye-stripe
Copy link
Contributor

Why?

#1485 revealed a bug with our nested array param encoding.

Confirmed the test failed before the fix, included v1 in the test instead of the correct param name a.

@helenye-stripe helenye-stripe requested review from a team and jar-stripe and removed request for a team November 13, 2024 19:06
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@helenye-stripe helenye-stripe merged commit 56b9950 into master Nov 15, 2024
14 checks passed
@helenye-stripe helenye-stripe deleted the helenye-fix-params branch November 15, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants