Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic settings api #232

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Generic settings api #232

wants to merge 2 commits into from

Conversation

sjaeckel
Copy link
Member

Introduce generic xmpp_conn_set_*() API

Instead of having a multitude of setter API functions for configuration options, provide generic ones for the different types we have.

@sjaeckel sjaeckel requested a review from pasis January 29, 2024 11:32
@sjaeckel sjaeckel marked this pull request as draft January 29, 2024 11:33
@sjaeckel
Copy link
Member Author

@pasis what do you think of this idea?

@pasis
Copy link
Member

pasis commented Jan 30, 2024

@pasis what do you think of this idea?

I like the direction. But JID (and probably password) sounds to me like something more important than just a setting. Not critical, just my preferences.

@sjaeckel
Copy link
Member Author

sjaeckel commented Jan 30, 2024 •
edited
Loading

I like the direction.

Cool! Nice to hear.

But JID (and probably password) sounds to me like something more important than just a setting.

I also thought about whether there's some more important things that deserve a separate API and the JID/password was on that list. I ended up putting everything in there, since if you use SASL-EXTERNAL via client certificates to authenticate, there's no JID (or password) required. You could give a JID, if you want to authenticate as a different user than given in the certificate, but that's just an option.

@sjaeckel sjaeckel force-pushed the generic-settings-api branch 2 times, most recently from 8f4a9cd to 0ce84f8 Compare January 31, 2024 16:09
@sjaeckel sjaeckel force-pushed the xep-0138 branch 2 times, most recently from 0d573b4 to 3f03de0 Compare January 31, 2024 19:39
Base automatically changed from xep-0138 to master January 31, 2024 22:30
@sjaeckel
Copy link
Member Author

@singpolyma do you have an opinion on this PR?

@singpolyma
Copy link

feels more or less the same to me. a matter of taste

@sjaeckel
Introduce generic xmpp_conn_set_*() API
06f2ba1 
Instead of having a multitude of setter API functions for configuration
options, provide generic ones for the different types we have.

Signed-off-by: Steffen Jaeckel <[email protected]>
@sjaeckel
Allow configuring compression level
541c22c 
Signed-off-by: Steffen Jaeckel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasis pasis Awaiting requested review from pasis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjaeckel @pasis @singpolyma