Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version flag to operator binary #2752

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Add version flag to operator binary #2752

merged 2 commits into from
Aug 7, 2023

Conversation

vthapar
Copy link
Contributor

@vthapar vthapar commented Aug 2, 2023

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2752/vthapar/version-flag
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@vthapar vthapar self-assigned this Aug 2, 2023
sridhargaddam
sridhargaddam requested changes Aug 4, 2023
View reviewed changes
main.go Outdated
@@ -51,27 +51,30 @@ import (
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
)

const componentName = "submariner-operator"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than redefining the component name, we can use the constant from

submariner-operator/pkg/names/names.go

Line 31 in ffeb0c0

OperatorComponent = "submariner-operator"

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 7, 2023
@tpantelis tpantelis enabled auto-merge (rebase) August 7, 2023 15:35
@tpantelis
Copy link
Contributor

The check_operator_version script needs to be updated.

@vthapar vthapar requested a review from mkolesnik as a code owner August 7, 2023 16:18
@vthapar
Add version flag to operator binary
b78368b 
Refer submariner-io/enhancements#204

Fixes submariner-io#2751

Signed-off-by: Vishal Thapar <[email protected]>
@vthapar
Use component names from admiral
e58b2c1 
Use admiral/pkg/names/names.go for component names for consistency
across all repos/components.

Signed-off-by: Vishal Thapar <[email protected]>
@tpantelis tpantelis closed this Aug 7, 2023
auto-merge was automatically disabled August 7, 2023 17:17

Pull request was closed

@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2752/vthapar/version-flag]

@tpantelis tpantelis reopened this Aug 7, 2023
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2752/vthapar/version-flag
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis tpantelis merged commit f29cd9e into submariner-io:devel Aug 7, 2023
37 of 38 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2752/vthapar/version-flag]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@tpantelis tpantelis tpantelis approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

Assignees

@vthapar vthapar

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add version flag to submariner-operator
4 participants
@vthapar @submariner-bot @tpantelis @sridhargaddam