Captioning updates #654
Merged
Captioning updates #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include some Japanese and use real examples (the first caption from Hashitomi and the second one from Kokaji).
simonwiles
force-pushed
the
captioning-updates
branch
from
940a4fa
to
cab1935
Compare
Remove unused code, unnecessary debug statement, update snapshots.
simonwiles
force-pushed
the
captioning-updates
branch
from
8a53236
to
57976be
Compare
simonwiles
force-pushed
the
captioning-updates
branch
from
57976be
to
dc72c6a
Compare
broadwell
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All but the most recent two commits date back just over a year.