Expanded shelfkeys to include additional information #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocument and consistently sortable in browse nearby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates some of the additional shelfkey sorting data from Searchworks:
https://github.com/sul-dlss/SearchWorks/blob/master/app/models/nearby_on_shelf.rb#L136-L160
By doing so, different documents with the same shelfkey will have a consistent sort order for pagination and we can ensure the user can see + paginate through the whole list of shelfkeys (see e.g. https://searchworks.stanford.edu/view/5129692 and other microforms for the worst case (65k identical call numbers))
TODO: