Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composer lint: phpstan No error to ignore is reported on line 17. #258

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from
Open

Fix composer lint: phpstan No error to ignore is reported on line 17. #258

wants to merge 2 commits into from

Commits on Nov 14, 2024

  1. Bump phpstan/phpstan to ^1.12 

    This includes a fix to issue phpstan/phpstan#7685 "Cast to (bool) on string|false !== false should end in non-empty-string"
    @RafaelKr
    RafaelKr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    370b4d5 View commit details
    Browse the repository at this point in the history

  2. Remove @phpstan-ignore-next-line from config/router.php 

    Since phpstan v1.12.1 the related issue is fixed.
phpstan/phpstan#7685
phpstan/phpstan-src#3380
    @RafaelKr
    RafaelKr committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    09897f8 View commit details
    Browse the repository at this point in the history