Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to recursively consider server dirs in $lib #12733

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rChaoz
Copy link

@rChaoz rChaoz commented Sep 28, 2024

Closes #12732

This PR adds a new config option kit.files.nestedServerDirs that, when enabled, considers any modules inside any $lib/**/server/** directory a server module, rather than just $lib/server/**.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Sep 28, 2024

🦋 Changeset detected

Latest commit: 9746640

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rChaoz rChaoz changed the title Add option to recursively consider server dirs in $lib feat: add option to recursively consider server dirs in $lib Sep 28, 2024
@eltigerchino
Copy link
Member

Instead of adding an option, can we instead make this the default? Would that be considered a breaking change?

@eltigerchino eltigerchino added the feature request New feature or request label Oct 6, 2024
@paoloricciuti
Copy link
Member

Instead of adding an option, can we instead make this the default? Would that be considered a breaking change?

Yes because if for some reason I'm importing a module on the client from /server/nested/module.ts it will fail with this

@eltigerchino eltigerchino added needs-decision Not sure if we want to do this yet, also design work needed breaking change and removed needs-decision Not sure if we want to do this yet, also design work needed breaking change labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request needs-decision Not sure if we want to do this yet, also design work needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to consider lib/**/server/** as server files
3 participants