[lldb] Adjust module name for types with @_originallyDefinedIn #9401
+171
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler generates types with @_originallyDefinedIn as a child of the original module, but with the ABI module in the mangled name. Before looking up types in reflection metadata, adjust the type's mangled name to use the original module name, since that's what's stored in reflection metadata. rdar://137146961
kastiglione
reviewed
Oct 9, 2024
Comment on lines
+3029
to
+3034
| // Find the type's module node. | ||
| while (child && child->getKind() != Node::Kind::Module && | ||
| child->hasChildren()) { | ||
| parent = child; | ||
| child = child->getFirstChild(); | ||
| } |
There was a problem hiding this comment.
what about a concrete generic type, would its type parameters need to have their modules replaced?
There was a problem hiding this comment.
Yeah you're right, this won't work if the type parameters are annotated with originallyDefinedIn
kastiglione
reviewed
Oct 9, 2024
| ts->GetTypeSystemSwiftTypeRef().GetCachedType(type.GetMangledTypeName()); | ||
|
|
||
| if (!lldb_type) { | ||
| LLDB_LOGV(GetLog(LLDBLog::Types), |
There was a problem hiding this comment.
this log is verbose but the following ones are not. Should this be non-verbose?
| let a = A() | ||
| let b = Alias() | ||
| let d = C.D() | ||
| let e = E<Prop>.t(Prop()) |
There was a problem hiding this comment.
re my comment about concrete generic types, could you add one ore more generic variables? Ex:
let f: A? = A()
let g = [A()]
let h: E<A> .t(A())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler generates types with @_originallyDefinedIn as a child of the original module, but with the ABI module in the mangled name. Before looking up types in reflection metadata, adjust the type's mangled name to use the original module name, since that's what's stored in reflection metadata.
rdar://137146961