Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #226

Open
sylefeb opened this issue Jul 6, 2022 · 1 comment
Open

Versioning #226

sylefeb opened this issue Jul 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@sylefeb
Copy link
Owner

sylefeb commented Jul 6, 2022

A versioning approach needs to be defined:

  • tags on master branch on new versions (when merging from wip), where the tag is an actual version string (good practices?)
  • --version should display these
  • versions in wip and draft could say wip-<hash> or draft-<hash>
@sylefeb sylefeb added the enhancement New feature or request label Jul 6, 2022
@trabucayre
Copy link
Contributor

Hi.
maybe adding, in compile_silice_linux.sh, something like do the job:

BRANCH=$(git branch --show-current)
if [ $BRANCH == "master" ]; then
    GIT_VERS=$(git describe --tags)
else
    GIT_VERS="$BRANCH-$(git rev-parse --short $(git branch --show-current))"
fi
cmake -DGIT_VERS=$GIT_VERS -DCMAKE_BUILD_TYPE=Release -G "Unix Makefiles" ../..

Ok it's linux only but a similar piece of code may works for others OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants