Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Synapse create3 factory #282

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

ChiTimesChi
Copy link
Collaborator

Description

Adds a Create3 Factory, that allows to deploy arbitrary bytecode on a deterministic address, that does not change, when the bytecode of the contract changes.

Could be used for user-facing contracts that could benefit from having the same address on different chains, even though they have different constructor arguments.

Note: the deployed contract must not use msg.sender in the constructor, as if will not be the deployer's EOA. For instance, if the contract is Ownable, it must consume newOwner as the constructor argument and transfer ownership there.

Checklist

  • New Contracts have been tested
  • Lint has been run
  • I have checked my code and corrected any misspellings

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6024094742

  • 0 of 18 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 13.803%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/create3/SynapseCreate3Factory.sol 0 8 0.0%
contracts/create3/libs/Create3.sol 0 10 0.0%
Totals Coverage Status
Change from base Build 6016670084: -0.06%
Covered Lines: 664
Relevant Lines: 4380

💛 - Coveralls

@ChiTimesChi ChiTimesChi marked this pull request as draft October 19, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants