Remove PRNGFixes file #2036
Merged
Remove PRNGFixes file #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamszewe
force-pushed
the
remove-prngfixes-workaround-file
branch
from
214ea46
to
d954c44
Compare
adamszewe
commented
Jan 5, 2024
| public static void apply() { | ||
| applyOpenSSLFix(); | ||
| installLinuxPRNGSecureRandom(); | ||
| } |
There was a problem hiding this comment.
The first method checks whether the SDK version is lower than 16 or higher than 18.
The second method checks only whether it's higher than 18.
The current min sdk version for the app is 21, thus the rest of the class is never executed.
imsodin
approved these changes
Jan 7, 2024
imsodin
pushed a commit
that referenced
this pull request
Jan 7, 2024
Refactor code inside `if-else` blocks that checks for versions that are no longer relevant. Few lines could be deleted some others were just un-wrapped from the if-else blocks. The `if-else` blocks inside `PRNGFixes` file were left out as this file is should be deleted in #2036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security workarounds contained in the
PRNGFixesclass were needed for devices older Android APIs (16, 17, 18) while the current min sdk API is 21.Therefore this workaround is no longer needed.