V inner boundary solver workflow #2797
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solvers pass info to each other Simplified some parts
Also adds docstrings to methods. Updates some methods to use new functionality of the plasma. Adds requirements for the convergence plots (still broken)
…wfullard/tardis into v_inner_solver_restructure
Also adds docstrings to methods. Updates some methods to use new functionality of the plasma. Adds requirements for the convergence plots (still broken)
…wfullard/tardis into v_inner_solver_restructure
…nt robot overlords
…wfullard/tardis into v_inner_solver_restructure
|
|
||
| class InnerVelocitySimulationSolver(SimpleSimulation): | ||
|
|
||
| TAU_TARGET = np.log(2.0 / 3) |
There was a problem hiding this comment.
For style reasons I would prefer 2. / 3.
|
|
||
| TAU_TARGET = np.log(2.0 / 3) | ||
|
|
||
| def __init__(self, configuration, mean_optical_depth="rossland", tau=None): |
There was a problem hiding this comment.
It's spelled rosseland
| Extrapolate with exponential fits | ||
|
|
||
| Need some way to return and inspect the optical depths for later logging""" | ||
| pass |
There was a problem hiding this comment.
This does nothing, currently?
| self.plasma_solver.plasma_solver_settings.RADIATIVE_RATES_TYPE | ||
| == "dilute-blackbody" | ||
| ): | ||
| j_blues = radiation_field.calculate_mean_intensity( |
There was a problem hiding this comment.
Do these not need to be masked in the same way as for detailed rates?
| planckian_radiation_field = ( | ||
| radiation_field.to_planckian_radiation_field() | ||
| ) | ||
| j_blues = planckian_radiation_field.calculate_mean_intensity( |
There was a problem hiding this comment.
Do these not need to be masked in the same way as for detailed rates?
|
@Rodot- this needs to be rebased now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝
Adds a workflow to solve for the v_inner_boundary of the simulation
Based on PR #2730 Which should be merged first
Type: 🚀
featureThis adds a complete workflow as a subclass of the SimpleSimulation workflow from PR #2730. This workflow adds convergence criteria and handling the the inner-boundary velocity value. This PR also makes small edits to the configuration schema and parser to allow accessing properties of the v_inner_boundary convergence.
📌 Resources
A notebook is provided in tardis/docs/workflows
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel