Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TARDISData dataclass to hold data about atoms #2812

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

andrewfullard
Copy link
Contributor

📝 Description

Type: 🚀 feature

This class will store the unfiltered data about atoms, ions et al. for the TARDIS plasma and transport. Name suggestions welcome.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 27, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (447b71b).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

3	G004 	[ ] Logging statement uses f-string
1	FA102	[*] Missing `from __future__ import annotations`, but uses PEP 604 union
1	G001 	[ ] Logging statement uses `str.format`
1	E902 	[ ] No such file or directory (os error 2)
1	UP030	[*] Use implicit references for positional format fields

Complete output(might be large):

.github/workflows/codespell.yml:1:1: E902 No such file or directory (os error 2)
tardis/io/atom_data/base.py:199:34: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:264:17: G004 Logging statement uses f-string
tardis/io/atom_data/base.py:268:21: UP030 Use implicit references for positional format fields
tardis/io/atom_data/base.py:268:21: G001 Logging statement uses `str.format`
tardis/io/atom_data/base.py:734:17: G004 Logging statement uses f-string
tardis/plasma/assembly/base.py:132:22: FA102 Missing `from __future__ import annotations`, but uses PEP 604 union
Found 7 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

@wkerzendorf
Copy link
Member

So the TARDIS Data class is now mirroring atomic data, correct? I would put it in the a new tardis_data.py package then.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 70.67%. Comparing base (b79b61e) to head (dc4c9d3).

Files Patch % Lines
tardis/io/atom_data/tardis_data.py 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2812      +/-   ##
==========================================
- Coverage   70.96%   70.67%   -0.30%     
==========================================
  Files         209      210       +1     
  Lines       15638    15665      +27     
==========================================
- Hits        11098    11071      -27     
- Misses       4540     4594      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants