Remove integration tests #2844
Open
Remove integration tests #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
*beep* *bop* 15 E902 No such file or directory (os error 2)
Complete output(might be large): tardis/tests/integration_tests/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/at/abundances.dat:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/at/config.yml:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/at/densities.dat:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/conftest.py:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/paper1_downbranch/config.yml:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/paper1_macroatom/abundances.dat:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/paper1_macroatom/config.yml:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/paper1_macroatom/densities.dat:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/paper1_scatter/config.yml:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/runner.py:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/test_integration.py:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/w7/abundances.dat:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/w7/config.yml:1:1: E902 No such file or directory (os error 2)
tardis/tests/integration_tests/w7/densities.dat:1:1: E902 No such file or directory (os error 2)
Found 15 errors.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2844 +/- ##
==========================================
- Coverage 69.97% 69.87% -0.11%
==========================================
Files 216 214 -2
Lines 16077 15981 -96
==========================================
- Hits 11250 11166 -84
+ Misses 4827 4815 -12 ☔ View full report in Codecov by Sentry. |
|
*beep* *bop* Significantly changed benchmarks: All benchmarks: Benchmarks that have stayed the same:
| Change | Before [5f116263] <master> | After [f010b752] | Ratio | Benchmark (Parameter) |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
| | 3.02±0.4μs | 3.61±0.4μs | ~1.20 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell |
| | 571±200ns | 641±100ns | ~1.12 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation |
| | 19.0±4μs | 21.4±5μs | ~1.12 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
| | 2.70±0.6μs | 2.99±0.4μs | ~1.11 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket |
| | 5.80±0.8μs | 6.46±0.6μs | ~1.11 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket |
| | 46.2±20μs | 41.8±20μs | ~0.90 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission |
| | 1.57±0.3μs | 1.40±0.4μs | ~0.89 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line |
| | 45.8±20μs | 49.1±30μs | 1.07 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter |
| | 3.44±0.01ms | 3.65±0ms | 1.06 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') |
| | 734±0.5ns | 774±0.4ns | 1.05 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter |
| | 204±0.2ns | 210±0.4ns | 1.03 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body |
| | 541±100ns | 550±100ns | 1.02 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation |
| | 2.71±0ms | 2.76±0.01ms | 1.02 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') |
| | 2.08±1μs | 2.11±1μs | 1.02 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators |
| | 30.6±0.04μs | 30.9±0.02μs | 1.01 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list |
| | 541±200ns | 541±100ns | 1.00 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation |
| | 2.07±0m | 2.06±0m | 1.00 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions |
| | 1.20±0μs | 1.20±0μs | 1.00 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary |
| | 40.2±0.04s | 39.9±0.05s | 0.99 | run_tardis.BenchmarkRunTardis.time_run_tardis |
| | 1.06±0m | 1.05±0m | 0.99 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking |
| | 1.67±0.01ms | 1.66±0.01ms | 0.99 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop |
| | 2.58±0.4ms | 2.55±0.4ms | 0.99 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop |
| | 7.30±2μs | 7.24±2μs | 0.99 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley |
| | 64.5±0.2ms | 63.4±0.01ms | 0.98 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe |
If you want to see the graph of the results, you can check it here |
|
Can you check that the configuration yml files are stored in https://github.com/tardis-sn/tardis-setups ? |
I dont think its there. Should I create a new dir and copy only the config files in that repo? |
Yes, make sure these configurations are stored there in some form. |
|
andrewfullard
previously approved these changes
Oct 28, 2024
KasukabeDefenceForce
force-pushed
the
remove_integration
branch
from
661aba0
to
f010b75
Compare
andrewfullard
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructureThis PR removes the outdated integration tests.
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel