Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapped Pool Size to be managed in Spring Properties #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Crain-32
Copy link

Description of changes:

  • Swapped hardcoded value to be a Spring Property

You can validate the pool size being set by using the follow breakpoints.
TaskSchedulingConfigurations.TaskSchedulerBuilderConfiguration::taskSchedulerBuilder sets the builder from the properties.
TaskSchedulingConfigurations.TaskSchedulerConfiguration::taskScheduler builds your ThreadPoolTaskScheduler using that builder.

A similar swap can be done for your CaffeineCacheManager, which you can dig into here. Which can be beneficial for testing where your MockCacheManager can instead just be spring.cache.type=SIMPLE

@Crain-32 Crain-32 requested a review from arpal7 as a code owner March 28, 2024 18:49
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants