feat(cli): enhance Android dev port forwarding, use host IP for android devices, closes #11137 #11185
Conversation
this changes the `android dev` port forwarding (that is actually handled by the `android-studio-script` command - triggered by our Gradle plugin) with some enhancements: - make the whole process more resilient by checking if the port was actually forwarded and rerunning the `adb reverse` command until it tells us the forward is ready - if the `adb devices` list is empty, retry a few times (waiting a few seconds) to tolerate devices being booted - slows down "raw builds" (Build Project Android Studio menu for instance) that shouldn't happen often anyway - if you're running `android dev` you're usually running the app on a device instead of simply testing builds
Package Changes Through 5e2dbbaThere are 5 changes which include tauri with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-bundler with prerelease, tauri-macos-sign with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
i'm only able to test this on the emulators - but the same should apply to physical devices i'm not at home right now and do not have access to my Android device.. |
|
This still doesn't work on my physical android device. I didn't have any issue with emulators before this PR, only with physical device. I tried with a couple of android devices and the same error persists. This is what I see on the app when opened:
|
|
ok i'm stealing a phone right now |
lucasfernog
changed the title
|
I gave up and we're now using the host IP when running on physical devices; the port forwarding isn't reliable and it doesn't even work if the device is connected via wi-fi (though the cause of the reported issue is still unclear to me) |
this changes the
android devport forwarding (that is actually handled by theandroid-studio-scriptcommand - triggered by our Gradle plugin) with some enhancements:adb reversecommand until it tells us the forward is readyadb deviceslist is empty, retry a few times (waiting a few seconds) to tolerate devices being booted - slows down "raw builds" (Build Project Android Studio menu for instance) that shouldn't happen often anyway - if you're runningandroid devyou're usually running the app on a device instead of simply testing builds