src/core: remove unnecessary includes

these unused includes are identified by clangd. see https://clangd.llvm.org/guides/include-cleaner#unused-include-warning for more details on the "Unused include" warning. Signed-off-by: Kefu Chai <[email protected]>
tchaikov · Jul 10, 2024 · 10a6fe3 · 10a6fe3
1 parent 52f1ec2
commit 10a6fe3
Show file tree

Hide file tree

Showing 16 changed files with 4 additions and 25 deletions.
diff --git a/include/seastar/core/future.hh b/include/seastar/core/future.hh
@@ -23,7 +23,6 @@
 
 #ifndef SEASTAR_MODULE
 #include <cassert>
-#include <concepts>
 #include <cstdlib>
 #include <cstring>
 #include <functional>

diff --git a/src/core/fair_queue.cc b/src/core/fair_queue.cc
@@ -25,15 +25,10 @@ module;
 
 #include <chrono>
 #include <functional>
-#include <queue>
-#include <unordered_set>
 #include <utility>
 #include <boost/container/small_vector.hpp>
 #include <boost/intrusive/parent_from_member.hpp>
 
-#include "fmt/format.h"
-#include "fmt/ostream.h"
-
 #ifdef SEASTAR_MODULE
 module seastar;
 #else

diff --git a/src/core/file.cc b/src/core/file.cc
@@ -27,7 +27,6 @@ module;
 #include <atomic>
 #include <coroutine>
 #include <deque>
-#include <filesystem>
 #include <functional>
 #include <memory>
 #include <optional>

diff --git a/src/core/io_queue.cc b/src/core/io_queue.cc
@@ -23,10 +23,7 @@
 module;
 #endif
 
-#include <compare>
-#include <atomic>
 #include <cassert>
-#include <array>
 #include <chrono>
 #include <cstdint>
 #include <mutex>

diff --git a/src/core/linux-aio.cc b/src/core/linux-aio.cc
@@ -23,7 +23,6 @@
 module;
 #endif
 
-#include <compare>
 #include <atomic>
 #include <algorithm>
 #include <cerrno>

diff --git a/src/core/memory.cc b/src/core/memory.cc
@@ -74,12 +74,11 @@ module;
 #endif
 
 #include <cassert>
-#include <concepts>
 #include <unordered_set>
 #include <iostream>
 #include <optional>
-#include <thread>
 #include <memory_resource>
+#include <thread>
 
 #include <fmt/format.h>
 #include <fmt/ostream.h>

diff --git a/src/core/on_internal_error.cc b/src/core/on_internal_error.cc
@@ -23,7 +23,6 @@
 module;
 #endif
 
-#include <compare>
 #include <atomic>
 #include <exception>
 #include <stdexcept>

diff --git a/src/core/prefault.hh b/src/core/prefault.hh
@@ -21,7 +21,6 @@
 #pragma once
 
 #include <atomic>
-#include <map>
 #include <optional>
 
 #include <seastar/core/posix.hh>

diff --git a/src/core/reactor.cc b/src/core/reactor.cc
@@ -23,7 +23,6 @@
 module;
 #endif
 
-#include <compare>
 #include <atomic>
 #include <cassert>
 #include <chrono>
@@ -34,7 +33,6 @@ module;
 #include <regex>
 #include <thread>
 
-#include <cinttypes>
 #include <spawn.h>
 #include <sys/syscall.h>
 #include <sys/vfs.h>

diff --git a/src/core/reactor_backend.cc b/src/core/reactor_backend.cc
@@ -22,7 +22,6 @@
 module;
 #endif
 
-#include <compare>
 #include <atomic>
 #include <cassert>
 #include <chrono>

diff --git a/src/core/reactor_backend.hh b/src/core/reactor_backend.hh
@@ -33,7 +33,6 @@
 #ifndef SEASTAR_MODULE
 #include <fmt/ostream.h>
 #include <sys/time.h>
-#include <signal.h>
 #include <thread>
 #include <stack>
 #include <boost/any.hpp>

diff --git a/src/core/scollectd.cc b/src/core/scollectd.cc
@@ -30,7 +30,6 @@ module;
 #include <cstdint>
 #include <functional>
 #include <unordered_map>
-#include <forward_list>
 #include <utility>
 #include <string>
 #include <map>

diff --git a/src/core/smp.cc b/src/core/smp.cc
@@ -23,7 +23,7 @@ module;
 #endif
 
 #include <boost/range/algorithm/find_if.hpp>
-#include <memory>
+#include <atomic>
 #include <vector>
 #include <regex>
 #include <sys/mman.h>

diff --git a/src/core/systemwide_memory_barrier.cc b/src/core/systemwide_memory_barrier.cc
@@ -27,7 +27,6 @@ module;
 #include <unistd.h>
 #include <cassert>
 #include <atomic>
-#include <mutex>
 
 #if SEASTAR_HAS_MEMBARRIER
 #include <linux/membarrier.h>

diff --git a/src/core/thread.cc b/src/core/thread.cc
@@ -24,10 +24,11 @@ module;
 #endif
 
 #include <ucontext.h>
+#ifndef SEASTAR_ASAN_ENABLED
 #include <setjmp.h>
+#endif
 #include <stdint.h>
 #include <valgrind/valgrind.h>
-#include <algorithm>
 #include <exception>
 #include <utility>
 #include <boost/intrusive/list.hpp>

diff --git a/src/core/vla.hh b/src/core/vla.hh
@@ -23,9 +23,7 @@
 
 #include <seastar/core/aligned_buffer.hh>
 #include <memory>
-#include <new>
 #include <assert.h>
-#include <type_traits>
 
 namespace seastar {