Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to impl/intf from preprocess_* #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anmonteiro
Copy link
Collaborator

@anmonteiro anmonteiro commented Apr 6, 2023

check the different ppxlib preprocessing phases: https://twitter.com/_anmonteiro/status/1644031054544789504

we want to run graphql_ppx in the "global transformations" phase, in order to allow graphql_ppx to be used with other PPXes that use the preprocess phase.

@jakubrpawlowski
Copy link

With this change I'm seeing the following warning in every file with autogenerated graphql types:

Error (warning 61 [unboxable-type-in-prim-decl]): This primitive declaration uses type Raw.t, whose representation
may be either boxed or unboxed. Without an annotation to indicate
which representation is intended, the boxed representation has been
selected by default. This default choice may change in future
versions of the compiler, breaking the primitive implementation.
You should explicitly annotate the declaration of Raw.t
with [@@boxed] or [@@unboxed], so that its external interface
remains stable in the future.

Branch: jchavarri@1663b3f

@anmonteiro
Copy link
Collaborator Author

anmonteiro commented Dec 14, 2023

It sounds unlikely that this branch would cause those warnings. Rather, they might be related to Melange, not the PPX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants