Support --workdir-root in the tmt clean command

[skycastlelily]

Pull Request Checklist

• implement the feature
• extend the test coverage
• include a release note

[skycastlelily]

Hi Petr, @psss, would you please spare some time to review this merge request,please? This is supposed to address #2807 , sorry for forgetting mentioned it before 1.36 release,and hope we can have this merged for 1.37: )

[martinhoyer]

lgtm. Just nitpicks.
I'm surprised setting a workdir root is so complicated tbh (not necessarily related to these changes). :)

[thrix]

@skycastlelily would it be possible to log the workdir root please in case the verbose mode is enabled please?

Something like:

❯ env | grep WORKDIR
TMT_WORKDIR_ROOT=/var/home/mvadkert/.local/share/tmt

❯ tmt clean -v
clean
    workdir /var/home/mvadkert/.local/share/tmt
guests
runs
images
    testcloud

[psss]

I've also moved the release note to the proper section and adjusted the wording a bit.

Seems the release note adjustment has been lost during rebase, added back in 7a0adc4. Please fetch the latest content from the branch before force-pushing new changes.

There is a couple of tests failing:

/tests/clean/guests
/tests/clean/runs
/tests/status/base

The error seems to be related:

status() missing 1 required positional argument: 'workdir_root'

Please, have a look. Thanks. Not ready for 1.39, moving to 1.40.

[skycastlelily]

Please fetch the latest content from the branch before force-pushing new changes

Will keep that on mind:)

The error seems to be related:

I guess it is because my commit to address that error is somehow removed during the rebase，anyway,gonna to have it back:)

[skycastlelily]

I guess it is because my commit to address that error is somehow removed

Yeah, that's the problem, added it back:4b61e18.

Not ready for 1.39, moving to 1.40.

We have lots of reviews, and commits for this mr, the "new" error is due to the commit to address the error is gone during rebase,hmm,lead, would you please,or do you see any chance we could have this mr released with 1.39 to avoid rebase mess 😿 🥺 ? 😁

[psss]

Sorry for that. I was ready to include it in the release but tests were red. And we cannot postpone the release indefinitely. Let's merge the pull request as one of the first ones in 1.40 to prevent any further rebase problems.

[psss]

The status definition has been moved to a separate file status.py. Please, move the changes there.