Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for multiple same checks per test #3332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinhoyer
Copy link
Collaborator

Pull Request Checklist

  • implement the feature

@martinhoyer martinhoyer added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. area | check Test check implementation labels Oct 31, 2024
@martinhoyer martinhoyer self-assigned this Oct 31, 2024
@happz
Copy link
Collaborator

happz commented Oct 31, 2024

@martinhoyer what about making it a linter check? In the normalization callback, the context it can provide is much smaller: yes, it reports multiple checks of the same how, but for which test? The callback does not see its "parent" object, therefore it cannot share this info. A linter check on test-level could.

@martinhoyer
Copy link
Collaborator Author

@martinhoyer what about making it a linter check? In the normalization callback, the context it can provide is much smaller: yes, it reports multiple checks of the same how, but for which test? The callback does not see its "parent" object, therefore it cannot share this info. A linter check on test-level could.

Make sense, will look into it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | check Test check implementation code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants