When everywhere #3340
When everywhere #3340
Conversation
lukaszachy
force-pushed
the
when-everywhere
branch
from
dc46687
to
8182196
Compare
lukaszachy
added
the
ci | full test
Use case: enable particular step configuration only on some environments
lukaszachy
force-pushed
the
when-everywhere
branch
from
8182196
to
5efcfc5
Compare
lukaszachy
requested review from
psss,
happz,
thrix and
janhavlin
as code owners
lukaszachy
added
specification
docs/releases.rst
Outdated
| It is easier limit when step configuration is run by | ||
| using :ref:`when-config` key. |
There was a problem hiding this comment.
| It is easier limit when step configuration is run by | |
| using :ref:`when-config` key. | |
| It is easier to limit a step execution using | |
| the :ref:when-config key. |
|
|
||
| prepare: | ||
| - name: Prepare config to run only on Fedora | ||
| when: distro == fedora |
There was a problem hiding this comment.
@lukaszachy can we add an example for multiple when rules?
| in this way, it soon becomes difficult to read. | ||
|
|
||
| Using the ``when`` key makes it easier to restrict a step configuration | ||
| to run only if any of the specified rules matches. |
There was a problem hiding this comment.
so this means I can also use something like
when:
- distro == fedora && trigger = rhel-ci
- distro == centos && trigger = fedora-ci
?
There was a problem hiding this comment.
I would appreciate more examples here, to get the feel of what can be done here
| example: | | ||
| finish: | ||
| - name: finish config to run only on Fedora | ||
| when: distro == fedora |
There was a problem hiding this comment.
@lukaszachy could we add a test with multiple when rules maybe?
There was a problem hiding this comment.
Will change tests/steps/when/data/plan.fmf
docs/guide.rst
Outdated
| - name: Prepare config to run only on Fedora | ||
| when: distro == fedora | ||
| how: shell | ||
| script: ./fedora_specific. |
There was a problem hiding this comment.
| script: ./fedora_specific. | |
| script: ./fedora_specific.sh |
I assume? or no dot? Same below.
| summary: Conditional step configuration | ||
| description: | | ||
| Using the ``when`` key makes it easier to restrict a step configuration | ||
| to run only if any of the specified rules matches. |
There was a problem hiding this comment.
run only if any of the specified rules matches.
I wonder if we could better communicate to the user how does that look, perhaps an example like:
If you want mach all conditions(see fmf context documentation), use:
when: "distro == fedora and arch = x86_64"
If you want to mach at least one use:
when: "distro == fedora"
when: "arch = x86_64"
There was a problem hiding this comment.
Hm, nice idea but that is common for whole adjust madness so ... another PR?
There was a problem hiding this comment.
IMO context deserves whole section in https://tmt.readthedocs.io/en/stable/examples.html#
@martinhoyer there's definitely one situation when "enabled" needs an input, i.e. "Is this phase enabled on this guest?", and because of that I think we cannot reach a singular "Is this phase enabled?" property. |
lukaszachy
requested review from
martinhoyer,
thrix,
KwisatzHaderach and
happz
Pull Request Checklist