Support passing pubkeys to authorized_keys for mrack
#3354
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skycastlelily
requested review from
dav-pascual,
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
happz
reviewed
Nov 12, 2024
skycastlelily
added
the
ci | full test
skycastlelily
force-pushed
the
pubkey-mrack
branch
from
e01d3c7
to
35e6449
Compare
happz
reviewed
Nov 19, 2024
| If set, Beaker jobs will be submitted on behalf of ``USERNAME``. | ||
| Submitting user must be a submission delegate for the ``USERNAME``. | ||
| """, | ||
| normalize=tmt.utils.normalize_string_list) |
There was a problem hiding this comment.
public_key+public-key+multiple=True. There is alreadykey/--keykey, a singular form, and on the command line I can use it multiple times (--key foo --key bar --public-key baz ...)default_factory=listwill be better: it's a list, and an empty list is as good indication of "no keys to install" asNone, but it's simpler because it's still just a list. So,list[str]+default_factory=listshould work perfectly.helpseems to be copy-pasted & deserves an update.
There was a problem hiding this comment.
Updated^^ 83d8781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist