Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to discover tests directory after login #3357

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

falconizmi
Copy link
Collaborator

Pull Request Checklist

  • implement the feature

@falconizmi falconizmi self-assigned this Nov 12, 2024
@falconizmi falconizmi added command | login The login command used to access the guest ci | full test Pull request is ready for the full test execution labels Nov 12, 2024
tmt/steps/__init__.py Outdated Show resolved Hide resolved
tmt/steps/__init__.py Outdated Show resolved Hide resolved
@falconizmi
Copy link
Collaborator Author

falconizmi commented Nov 12, 2024

Solves issue #803
for tmt try, if user run tmt try --login, it wont run any tests as its how login was implemented:
-l, --login Log into the guest only, do not run any
and he will be logged in to worktree path

So the user needs to run tmt run -tests NAME then, when he will be asked what to do next, choose login option and in that case, he will be logged in test path

@falconizmi falconizmi added this to the 1.39 milestone Nov 12, 2024
@martinhoyer martinhoyer self-requested a review November 19, 2024 10:26
@falconizmi
Copy link
Collaborator Author

Okay, I have here some failures because the test path, that I expect, is /var/tmp/tmt/run-XXX/something/discover/default-0/, but instead when we have this test case:
plan

summary: Basic smoke test
execute:
    how: tmt
    script: tmt --help

and run it with this tmt command:
tmt run -a provision -h local --feeling-safe
and after the run take a look in the directory /var/tmp/tmt/run-XXX/something/discover/, there is no default-0/ directery.
And in the check, there is after that command tmt run -l login -c true, which will fail, because it executes the last run that doesnt have folder default-0/
(or at least that what I think now)

@psss psss linked an issue Nov 21, 2024 that may be closed by this pull request
@psss psss modified the milestones: 1.39, 1.40 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution command | login The login command used to access the guest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run tests with libraries after login to test machine
4 participants