Fix log paths for subresults loaded from tmt-report-results.yaml #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberm
added
bug
seberm
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
seberm
force-pushed
the
feature/fix-internal-subresults-log-path
branch
from
c46a241
to
2b4974d
Compare
seberm
added
the
code | trivial
This was referenced Nov 19, 2024
seberm
force-pushed
the
feature/fix-internal-subresults-log-path
branch
from
2b4974d
to
3eaaf33
Compare
seberm
removed
the
code | trivial
KwisatzHaderach
approved these changes
Nov 21, 2024
happz
approved these changes
Nov 21, 2024
seberm
force-pushed
the
feature/fix-internal-subresults-log-path
branch
from
3eaaf33
to
0920dba
Compare
psss
requested changes
Nov 21, 2024
There was a problem hiding this comment.
I quickly checked the generated results.yaml file and it does not seem to be correct. I used the following test:
cd tests/execute/restraint/report-result/data
tmt run --all test --name output report --how html --open
Seems that while the subresult logs have been fixed and are working fine the main result logs are now broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result/subresult log file path loaded from the
tmt-report-results.yamlfile must be modified to be relative toexecutedirectory the same way as forcustom/restraintresults (see ExecutePlugin._process_results_partials(...)).Pull Request Checklist