Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(input validation): fix examples for MaskedTextbox and Slider #1624

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

YanushevGeorgi
Copy link
Contributor

@YanushevGeorgi YanushevGeorgi commented Sep 8, 2023

Slider-related margin fix is due to telerik/kendo-themes#4698

@YanushevGeorgi YanushevGeorgi requested a review from a team September 8, 2023 10:12
@YanushevGeorgi YanushevGeorgi requested a review from a team as a code owner September 8, 2023 10:12
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the Slider height with some other CSS, which doesn't require knowledge about our components' CSS classes.

@dimodi dimodi added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Hello @dimodi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

Copy link
Contributor

@yordan-mitev yordan-mitev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanushevGeorgi YanushevGeorgi force-pushed the fix-inputvalidation-examples branch 2 times, most recently from 2e0acd7 to dc77465 Compare September 14, 2023 14:44
@YanushevGeorgi YanushevGeorgi merged commit 3bf0441 into master Sep 18, 2023
1 check passed
@github-actions
Copy link
Contributor

Here you are the link to your PR to production: 1649

@github-actions github-actions bot deleted the fix-inputvalidation-examples branch September 18, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants