Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(grid): Remove Save and Cancel command buttons from Popup Editing examples #2157

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

dimodi
Copy link
Contributor

@dimodi dimodi commented Jun 13, 2024

No description provided.

@dimodi dimodi added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Jun 13, 2024
@dimodi dimodi requested a review from a team June 13, 2024 06:27
@dimodi dimodi requested a review from a team as a code owner June 13, 2024 06:27
Copy link
Contributor

Hello @dimodi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@dimodi dimodi merged commit 89a98cb into master Jun 13, 2024
2 checks passed
Copy link
Contributor

Here you are the link to your PR to production: 2158

@github-actions github-actions bot deleted the popup-edit-fixes branch June 13, 2024 08:13
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.


To enable Popup editing in the grid, set its `EditMode` property to `Telerik.Blazor.GridEditMode.Popup`, then handle the CRUD events as shown in the example below.

The Popup editing mode supports [validation]({%slug common-features/input-validation%}). To use it, all you need to do is decorate your model with the desired annotations. Validation errors will be shown in the popup and will prevent the Update operation.


>caption The Command buttons and the grid events let you handle data operations in Popup edit mode (see the code comments for details)
>caption Grid popup editing example. Please review the code comments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cosmetic notes here:

  • If you need to use a period within the caption, it's best to use it consistently (that is in both sentences). Otherwise it looks a bit weird when rendered. However, I would recommend avoiding the period altogether by using parenthesis, for example.
  • Our style guide recommends avoiding "please". See here for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants