Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Use KVO to automatically respond correctly to changes in the extensionView size #124

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

evands
Copy link
Contributor

@evands evands commented Feb 29, 2016

Observe the frame of our extensionView and update automatically if it changes.

@Mazyod
Copy link
Contributor

Mazyod commented Feb 29, 2016

Thanks for the PR! I am working on some more examples in the demo, especially refresh and hopefully one where the extension view frame changes to demonstrate this. Once I create the example, I'd also want to explore subclassing UIView and using layoutSubviews instead of KVO to react to frame changes, since KVO is something I generally like to avoid.

Evan D. Schoenberg, M.D and others added 3 commits April 1, 2016 20:54
…iew can be shown by virtue of excess space available in the scrollview relative to its content view. However, it breaks at edge cases, including if the content is just a bit more than threshold and then the user scrolls down further via the elastic scrollview... the logic suddenly thinks enough space is available and leads to the extension expanding. Just disabling the logic for now.
@evands
Copy link
Contributor Author

evands commented Aug 23, 2016

Just a note that this remains an issue. I recently moved to using your newly refactored version (1.1.0) to get the corrections for a couple bugs and verified it remains. It'd be great to get this merged; in the meantime, I'm manually updating extensionViewContainer's frame via a category after I change the extension view size.

@StainlessStlRat
Copy link

Is this supposed to work now? I'm trying to change my extension frame size and nothing is happening

@evands
Copy link
Contributor Author

evands commented Nov 18, 2017

I revisited this a month or so ago and it remained nonworking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants