-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libpaper: remove _NL_PAPER_{WIDTH,HEIGHT} #21510
base: master
Are you sure you want to change the base?
Conversation
That explains the removal of Could you explain why the patch file was added? |
Cuz android's bionic ( Note; libreoffice's |
Thanks for the explanation. I think this change can be added in upstream.
|
Okay, made one here: rrthomas/libpaper#59 |
alternatively, partially revert 2148a3e, to this: termux_step_pre_configure() {
# 210x297 is A4 size. Hard code as default.
sed -i \
-e "s|NL_PAPER_GET(_NL_PAPER_WIDTH)|210|g" \
-e "s|NL_PAPER_GET(_NL_PAPER_HEIGHT)|297|g" \
"${TERMUX_PKG_SRCDIR}"/lib/libpaper.c.in.in
} or write an equivalent patch |
I do not hold strong view nor any preference on which approach. I just want to flag it. Feel free to change this PR. |
Discovered that
_NL_PAPER_WIDTH
and_NL_PAPER_HEIGHT
are not the size but they are C++enum
items (e.g. defined in langinfo.h) that is the input of std c lib funcnl_langinfo()
. Feeding 210 and 297 into that func may have unknown behavior.I discovered this as I am trying to build libreoffice and I encountered the similar issue in their
paper.cxx
.It may not have material impact on existing package, but just for correctness.