Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] kdenlive #21646

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

[WIP] kdenlive #21646

wants to merge 38 commits into from

Conversation

knyipab
Copy link
Contributor

@knyipab knyipab commented Oct 3, 2024

Should bring us closer to a complete KDE. Also prove that qt6-qt5compat #21573 is working.

Some dirty hacks applied on kf6-kconfig to build kdenlive. Help wanted to address such issue, see #21647.

@twaik
Copy link
Member

twaik commented Oct 3, 2024

I do not think using separate package for building with cross-compiler is a bad idea. There are a lot of packages like this. You can find a lot of *-cross*.subpackage.sh buildscripts in termux packages. But probably it will be better to move x11-packages/kf6-kconfig-cross/build.sh content to the regular kf6-config build script with moving cross-building stuff to subpackage. This way we will be sure both regular and cross-subpackage have the same version and updated simultaneously.

@knyipab
Copy link
Contributor Author

knyipab commented Oct 3, 2024

I agree that it should be in *-cross*.subpackage.sh. Just that kf6 (including kf6-kconfig) uses a lot of extra-cmake-modules syntax and I couldn't figure out a way to make host build cmake to work with that, so I opened #21647. FYI, kf6-kconfig-cross is a dirty hack to build kconfig_compiler_kf6 with pure cmake which I suppose not preferred.

By the way, this Github actions failed and behave differently than that of my branch. My branch is up-to-date and is still building it (https://github.com/knyipab/termux-packages/actions). I expect it to build successfully.

@knyipab
Copy link
Contributor Author

knyipab commented Oct 3, 2024

Few things to add:

  • forgot to mention that kf6-kconfig-cross requires $TERMUX_PREFIX/include/KF6/KConfig/kconfig_version.h to be available which is generated by cmake cross compilation, so I couldn't find easy way to put it as subpackage.
  • [edited] My branch build fails but for different reasons. I will fix that in coming few days. Still, I dunno why this upstream Github Actions behave differently.
  • At least my build (https://github.com/knyipab/termux-packages/actions/runs/11171466617) can run on my phone and is able load video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants