Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace to build.gradle for AGP > 7 #617

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add namespace to build.gradle for AGP > 7 #617

merged 1 commit into from
Apr 30, 2024

Conversation

stetbern
Copy link
Contributor

@stetbern stetbern commented Nov 9, 2023

React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x. See react-native-community/discussions-and-proposals#671.

This will require all the libraries to specify a namespace in their build.gradle file. See AGP release notes https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes#namespace-dsl

@stetbern stetbern changed the title feat: add namespace to build.gradle for AGP > 7 Add namespace to build.gradle for AGP > 7 Nov 9, 2023
@HollandMcQ2
Copy link

This change works for me 👍

Copy link
Contributor

@DavidBertet DavidBertet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @stetbern
#589 which is using Gradle 8.0.1 will need it

@scarlac scarlac merged commit 3135697 into teslamotors:master Apr 30, 2024
3 checks passed
@scarlac
Copy link
Collaborator

scarlac commented Apr 30, 2024

Thank you, @stetbern and @DavidBertet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants