use config by value instead of reference #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If block_device_mapping is using sequental kitchen test cases execution will fail Reason: during first run config is changing in get_bdm function because it is accessing by reference. So second test case will try to use volume from a first test case instead of creating a new volume. And it even will use those volume in case delete_on_termination is set to false
|
@Gorton218 can you please rebase to master? That should fix the linting errors on the tests. |
done |
|
@Gorton218 Can you please provide an example |
|
@Gorton218 ping |
|
Sorry, currently on vacation without laptop
…On Tue, Aug 4, 2020, 20:20 Lance Albertson ***@***.***> wrote:
@Gorton218 <https://github.com/Gorton218> ping
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#208 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNMGIQHJAJDN645VLOVJPLR7A7N3ANCNFSM4PLT4PXQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If block_device_mapping is using sequental kitchen test cases execution will fail
Reason: during first run config is changing in get_bdm function because it is accessing by reference. So second test case will try to use volume from a first test case instead of creating a new volume. And it even will use those volume in case delete_on_termination is set to false